Modify range metadata in indexing.jl#3026
Open
SuyashR25 wants to merge 3 commits intoJuliaGPU:masterfrom
Open
Conversation
Update range metadata to include stop + 1.
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/device/intrinsics/indexing.jl b/src/device/intrinsics/indexing.jl
index ae6f3836e..448d423dc 100644
--- a/src/device/intrinsics/indexing.jl
+++ b/src/device/intrinsics/indexing.jl
@@ -24,7 +24,9 @@ export
# attach range metadata
range_metadata = MDNode([ConstantInt(Int32(range.start)),
- ConstantInt(Int32(range.stop + 1))])
+ ConstantInt(Int32(range.stop + 1)),
+ ]
+ )
metadata(idx)[LLVM.MD_range] = range_metadata
ret!(builder, idx) |
maleadt
approved these changes
Feb 4, 2026
maleadt
requested changes
Feb 4, 2026
Member
maleadt
left a comment
maleadt
left a comment
There was a problem hiding this comment.
This seems to break things spectacularly, throwing an error from the _index generated function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3024
Update range metadata to include stop + 1.