Disallow StepRange{<:Quantity{<:AbstractFloat}}#560
Open
sostock wants to merge 3 commits intoJuliaPhysics:masterfrom
Open
Disallow StepRange{<:Quantity{<:AbstractFloat}}#560sostock wants to merge 3 commits intoJuliaPhysics:masterfrom
StepRange{<:Quantity{<:AbstractFloat}}#560sostock wants to merge 3 commits intoJuliaPhysics:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 87.93% 87.51% -0.42%
==========================================
Files 16 16
Lines 1450 1450
==========================================
- Hits 1275 1269 -6
- Misses 175 181 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For unitless numbers,
StepRangeenforces certain restrictions:However, for unitful quantities, these are currently allowed:
After this PR, the restrictions that apply to unitless numbers are also applied to unitful quantities. Closes #552.
Edit: We would have to drop support for Julia < 1.6 for this PR. I checked that it works with Julia 1.6 and 1.7.