Swap \; for \, in LatexifyExt and matching tests#810
Merged
sostock merged 4 commits intoJuliaPhysics:masterfrom Sep 16, 2025
Merged
Swap \; for \, in LatexifyExt and matching tests#810sostock merged 4 commits intoJuliaPhysics:masterfrom
\; for \, in LatexifyExt and matching tests#810sostock merged 4 commits intoJuliaPhysics:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
=========================================
Coverage ? 89.46%
=========================================
Files ? 21
Lines ? 1699
Branches ? 0
=========================================
Hits ? 1520
Misses ? 179
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Did you push cf9ad06 to the wrong branch? |
Contributor
Author
Yep, reverting that here |
cf9ad06 to
8442a36
Compare
Collaborator
|
For consistency, I would go with the third option, but it’s not a strong preference. |
8442a36 to
29c2a02
Compare
Contributor
Author
|
Consistency is good, I'll put the |
Contributor
|
No opinion, array times unit looks awkward either way, and when they are not side by side I doubt anyone will register the difference :D I like the PR in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As briefly discussed in #795 (comment), it's marginally more appealing to use a thin space (
\,) than the wider space (\;) between the number and unit of a quantity. This is also the default behavior in LaTeX's siunitx.This PR makes that change (fortunately a two-character change), as well as updating the corresponding tests.

Current master:
This PR:

The aspect which could depend on taste is that I also removed the spacing between an array and its unit, which seems to visually match the regular quantity spacing.
For arrays, options are:



With
\,(third optionthis PR): (\begin{equation} \left[ \begin{array}{c} 1 \\ 2 \\ 3 \\ \end{array} \right]\,\mathrm{m} \end{equation})With
\;(current master):With no extra spacing at all (
this PRformer version of this PR): (\begin{equation} \left[ \begin{array}{c} 1 \\ 2 \\ 3 \\ \end{array} \right]\mathrm{m} \end{equation})The one caveat I see to removing the space between array and unit is that, formally, the space should be left out when the unit is degrees, and so this puts other units at the same separation as degrees (instead of having an extra space).