Make AbstractQuantity a NestedNumbers.QuantityNumber#837
Draft
oschulz wants to merge 4 commits intoJuliaPhysics:masterfrom
Draft
Make AbstractQuantity a NestedNumbers.QuantityNumber#837oschulz wants to merge 4 commits intoJuliaPhysics:masterfrom
oschulz wants to merge 4 commits intoJuliaPhysics:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
=========================================
Coverage ? 88.93%
=========================================
Files ? 22
Lines ? 1591
Branches ? 0
=========================================
Hits ? 1415
Misses ? 176
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://discourse.julialang.org/t/flexunits-jl-0-3-0-support-for-unitful-like-inference/134903/38
Requires NestedNumbers.jl (working title, not registered yet), please see (and feel most welcome to take part in) the NestedNumbers design discussion.
(This PR temporarily includes a
[sources]entry in Project.toml files to pull in the NestedNumbers prototype, let's see it it works).See the NestedNumbers demo (includes Unitful use case).
This is a intended to be a starting point, everything is open to change, and the final approach should ideally include UnitsBase as well.
CC @sostock @giordano @Ickaser @aplavin