Remove NNMF problem and update Benchmark.jl accordingly#254
Merged
MohamedLaghdafHABIBOULLAH merged 2 commits intoJuliaSmoothOptimizers:paperfrom Oct 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the NNMF (Non-Negative Matrix Factorization) problem benchmarking code and cleans up dependencies. The changes eliminate the CFG2 configuration that was specifically used for NNMF benchmarks, remove ProximalOperators/ProximalAlgorithms dependencies in favor of ShiftedProximalOperators, and simplify solver naming in the remaining SVM benchmarks.
- Removes all NNMF-related benchmark functions and workflow
- Updates package dependencies to use ShiftedProximalOperators instead of ProximalOperators
- Simplifies solver naming by removing problem type suffixes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| paper/examples/example.jl | Updates imports to use ShiftedProximalOperators and adds NLPModelsModifiers |
| paper/examples/comparison-config.jl | Removes CFG2 configuration that was used for NNMF benchmarks |
| paper/examples/Project.toml | Removes ProximalOperators, ProximalAlgorithms, and ProximalCore dependencies |
| paper/examples/Benchmark.jl | Removes all NNMF benchmark functions and simplifies solver naming in SVM benchmarks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MaxenceGollier
approved these changes
Oct 20, 2025
28b0f38 to
fe6762f
Compare
badc31f
into
JuliaSmoothOptimizers:paper
2 checks passed
MohamedLaghdafHABIBOULLAH
added a commit
to MohamedLaghdafHABIBOULLAH/RegularizedOptimization.jl
that referenced
this pull request
Jan 22, 2026
…ptimizers#254) * Remove NNMF problem and update Benchmark.jl accordingly * Refactor SVM benchmark output formatting and improve LaTeX table generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo @MaxenceGollier this should be merged after 249.