Skip to content

adds an initialization value for the ratio in the solve function#319

Merged
MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom
BenjaminPINEAU:R2alg_def_ratio
Apr 13, 2026
Merged

adds an initialization value for the ratio in the solve function#319
MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom
BenjaminPINEAU:R2alg_def_ratio

Conversation

@BenjaminPINEAU
Copy link
Copy Markdown
Contributor

I suggest setting the initial value of the ratio to 0. In fact if verbose > 0 but there are 0 iterations, it results in the following error: exception = UndefVarError: ρk not defined in local scope

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.44%. Comparing base (e0f214d) to head (c90dad8).
⚠️ Report is 278 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #319       +/-   ##
===========================================
+ Coverage   61.53%   83.44%   +21.91%     
===========================================
  Files          11       12        +1     
  Lines        1292     1643      +351     
===========================================
+ Hits          795     1371      +576     
+ Misses        497      272      -225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxenceGollier
Copy link
Copy Markdown
Collaborator

Thank you!

@MaxenceGollier MaxenceGollier merged commit 6d78b08 into JuliaSmoothOptimizers:master Apr 13, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants