adds an initialization value for the ratio in the solve function#319
Merged
MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom Apr 13, 2026
Merged
Conversation
MaxenceGollier
approved these changes
Apr 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
===========================================
+ Coverage 61.53% 83.44% +21.91%
===========================================
Files 11 12 +1
Lines 1292 1643 +351
===========================================
+ Hits 795 1371 +576
+ Misses 497 272 -225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you! |
6d78b08
into
JuliaSmoothOptimizers:master
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest setting the initial value of the ratio to 0. In fact if verbose > 0 but there are 0 iterations, it results in the following error: exception = UndefVarError:
ρknot defined in local scope