refactor: replace complex pipe-closure with simple then_some#373
Merged
refactor: replace complex pipe-closure with simple then_some#373
then_some#373Conversation
Use `recursive.then_some("-R")` instead of `.pipe(|cmd| if recursive { cmd.with_arg("-R") } else { cmd })` for clearer intent.
https://claude.ai/code/session_01RNq8cLPfc5PEN4M8cQodwx
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the chmod command construction in cli_errors integration tests to avoid a conditional pipe closure by using bool::then_some with with_args, keeping behavior equivalent while simplifying the command chain.
Changes:
- Replace
pipe(|cmd| if recursive { ... } else { ... })with.with_args(recursive.then_some("-R"))infs_permission.
Performance Regression Reportscommit: 5f09a4b There are no regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01RNq8cLPfc5PEN4M8cQodwx