Fix INSTALL_FAILED_DUPLICATE_PERMISSION for apps with mixed-case perm…#18
Merged
Conversation
…ission names Apps like Walkabout Mini Golf declare custom permissions using a mixed-case variant of their package name (e.g. com.MightyCoconut.WalkaboutMiniGolf.PERMISSION when the package id is com.mightycoconut.walkaboutminigolf). The previous case-sensitive replacements missed these, leaving the renamed APK still declaring the original permission name — which the Horizon+ install already owns, causing a duplicate permission conflict at install time. - manifest-editor.js: add a final case-insensitive pass over the full manifest after targeted replacements, catching <permission>, <uses-permission>, and android:permission attributes that use any casing of the old package name. - smali-renamer.js: make the string-constant replace case-insensitive for the same reason (smali code may reference the mixed-case permission string). https://claude.ai/code/session_01Jn3iu5gKmBRf1fKqUygJoY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ission names
Apps like Walkabout Mini Golf declare custom permissions using a mixed-case variant of their package name (e.g. com.MightyCoconut.WalkaboutMiniGolf.PERMISSION when the package id is com.mightycoconut.walkaboutminigolf). The previous case-sensitive replacements missed these, leaving the renamed APK still declaring the original permission name — which the Horizon+ install already owns, causing a duplicate permission conflict at install time.
Should fix issue #17