Update Java bindings for HDR support#1147
Conversation
The first two are not specific to HDR. |
|
I have just create PR #1150 to add everything to the Python binding. Letting you know as it may be helpful. |
|
I'll have a closer look at the changes and will try add any changes that might be missing here. |
|
Most of the updates that are specific for the added HDR support should be done now. (I stumbled over the missing I'll add some further tests for the new functionality. One thing that is "unrelated" to the HDR changes: I noticed that the bindings for are missing, including the corresponding I'll try to allocate some time to add them (this could be a new PR, but 🤷♂️ it probably makes sense to just add them here...). |
MarkCallow
left a comment
There was a problem hiding this comment.
Looks good. Thanks. Some test coverage using the new tokens would be great, if time allows.
I am waiting for fixes to two other issues. I will hold off on merging this until those arrive to give you a window for adding ktxTexture2_GetColorModel_e and ktxTexture2_GetPrimaries_e to this PR. They should indeed be included in the Java wrapper.
The PR #1100 added HDR support.
This PR aims at updating the Java bindings accordingly. (EDIT: So it may fix #1144 , eventually...)
What is done until now:
UASTC_HDR_6X6_INTERMEDIATEsupercompression scheme enum valueRGBA_HALF/ASTC_HDR_4x4_RGBA/ASTC_HDR_6x6_RGBAtranscode format enum valuesKtxBasisCodecclass, corresponding to the codec enum, as requested in a review commentktxBasisParams(likeuastcHDRUltraQuantetc) to theKtxBasisParamsclassWhat remains to be done:
KTX_API ktx_bool_t KTX_APIENTRY ktxTexture1_IsTranscodable(ktxTexture1* This);functions (for
KtxTexture1andKtxTexture2)getColorModel,getTransferFunction,isHDR... ? Not yet looked at the details