Fix incorrect comments and add missing exit code in test script#32
Open
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Open
Fix incorrect comments and add missing exit code in test script#32assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Conversation
Add missing 'exit 1' when $HOME/trojan-source directory is not found, which previously caused the script to continue and fail confusingly. Fix swapped exit-code comments in process_file and correct comments that referenced unicode-show when the tested command was sanitize-string. https://claude.ai/code/session_01PfZGFapQ3TpfQYu7tUFYUx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects misleading comments in the unicode-testscript that incorrectly described exit codes, and adds a missing
exit 1statement to ensure proper error handling when the trojan-source repository is not found.Key Changes
unicode-showandsanitize-stringexit codes to match the actual conditional logicexit 1after the error message when the trojan-source folder is missing (line 100), ensuring the script terminates with an error code instead of continuing executionImplementation Details
The comments were misleading because they described the opposite of what the conditional statements actually checked. The exit code was missing in the folder validation check, which could allow the script to continue despite a critical dependency being unavailable.
https://claude.ai/code/session_01PfZGFapQ3TpfQYu7tUFYUx