Corrections and upgrade from Vue2 to Vue3#877

Open

UlysseDurand wants to merge 20 commits into

Kitware:masterfrom

UlysseDurand:docs-tutoriel-vue3

Contributor

UlysseDurand commented Apr 10, 2026

This PR depends on Kitware/trame-tutorial#7
because trame and trame-tutorial are referencing one another.

Correct the tutorial and upgrade it from Vue2 to Vue3.

Some corrections
- Code parts from Trame1 were remaining
- Code parts were not corresponding between doc and examples
Change vuetify to vuetify3 in the code
Change VSelect's items' text and value
Change toggle dark theme mechanism

UlysseDurand mentioned this pull request

Upgrade from Vue2 to Vue3 Kitware/trame-tutorial#7

Merged

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/layouts.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/layouts.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/layouts.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/paraview.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/paraview.md Outdated

Collaborator

jourdain commented Apr 14, 2026

I would update to the structure shown here: https://kitware.github.io/trame/examples/core/basics.html#class-for-trame-application

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/paraview.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/paraview.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/paraview.md Outdated

Collaborator

jourdain commented Apr 28, 2026

This branch cannot be rebased due to conflicts

Collaborator

jourdain commented Apr 28, 2026

Otherwise code looks good

UlysseDurand mentioned this pull request

Finish making all the examples use best practice Kitware/trame-tutorial#8

Merged

UlysseDurand commented

View reviewed changes

Contributor Author

UlysseDurand left a comment

All the examples are updated to use Trame's best practice (like using the TrameApp class).

The corresponding PR in the trame-tutorial repo is the following: Kitware/trame-tutorial#8

docs/vitepress/guide/tutorial/application.md Outdated

docs/vitepress/guide/tutorial/application.md

docs/vitepress/guide/tutorial/application.md Outdated

docs/vitepress/guide/tutorial/html.md

docs/vitepress/guide/tutorial/layouts.md Outdated

docs/vitepress/guide/tutorial/layouts.md Outdated

docs/vitepress/guide/tutorial/layouts.md Outdated

docs/vitepress/guide/tutorial/paraview.md Outdated

docs/vitepress/guide/tutorial/paraview.md Outdated

UlysseDurand added a commit to UlysseDurand/trame that referenced this pull request


          docs(tutorial): change small errors

56a48c1

- indentation errors
- forgot to put self in class function's arguments
- self.server.state => self.state
- one forgotten layout => self.ui

Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/application.md

UlysseDurand added a commit to UlysseDurand/trame that referenced this pull request


          docs(tutorial): make the setup tutorial example use TrameApp

ed4374b

Refs: Kitware#877 (comment)

UlysseDurand added a commit to UlysseDurand/trame-tutorial that referenced this pull request


          docs(tutorial): use AppLayouts instead of AppCone as class name

5a5c152

Ref: Kitware/trame#877 (comment)
Ref: Kitware/trame#877 (comment)

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/html.md Outdated

jourdain reviewed

View reviewed changes

docs/vitepress/guide/tutorial/vtk.md Outdated

UlysseDurand added a commit to UlysseDurand/trame that referenced this pull request


          docs(tutorial): change vuetify3 with v3 and server with `self.ser…

d6d8aa7

…ver`

Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)

Collaborator

jourdain commented May 12, 2026

You have to rebase and fix conflicts

Collaborator

jourdain commented May 12, 2026

You still have conflicts

Collaborator

jourdain commented May 12, 2026

It would have been better to rebase that merging master...

UlysseDurand added 20 commits

May 13, 2026 10:17


          docs(tutorial): change the doc to match the trame-tutorial update to …

4c7cf57

…vue3


          docs(examples): use cookiecutter's vuetify3 best practices

32ac8be


          docs(tutorial): correct example code and fix typos

43d20af


          docs(tutorial): use TrameApp in 04_applications

de39929


          docs(tutorial): use TrameApp in the paraview tutorial

77dcbc4


          docs(tutorial): change the html tutorial page to use trame's best pra…

bb61a53

…ctice


          docs(tutorial): update examples to use the TrameApp base class

1691e7b


          docs(tutorial): make the user import trame-components

94ca7ae

Ref: https://github.com/Kitware/trame/pull/877/changes/
BASE..94fddc8#r3076435029


          docs(tutorial): change small errors

1fe142b

- indentation errors
- forgot to put self in class function's arguments
- self.server.state => self.state
- one forgotten layout => self.ui

Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)


          docs(tutorial): change **kwargs with **_kwargs because they are unused

119a003

Ref: Kitware/trame-tutorial@adfd845


          docs(tutorial): remove view update when server ready

4c40119

Ref: Kitware/trame-tutorial#8 (comment)


          docs(tutorial): replace **_kwargs with **_

023a51a

Ref: Kitware/trame-tutorial#8 (comment)


          docs(tutorial): use self.server

fe95bd5

Ref: Kitware#877 (comment)


          docs(tutorial): use icon in VBtn parameter

93bcfa0

Ref: Kitware#877 (comment)


          docs(tutorial): put helper functions that don't need self out of class

accf740

Ref: Kitware#877 (comment)


          docs(tutorial): put self.server instead of server

6fbc373

Ref: Kitware#877 (comment)


          docs(tutorial): use AppLayouts instead of AppCone as class name

71952cc

Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)


          docs(tutorial): make the setup tutorial example use TrameApp

f6599b3

Refs: Kitware#877 (comment)


          docs(tutorial): change AppLayouts class name to ConeApp

22edb0f


          docs(tutorial): change vuetify3 with v3 and server with `self.ser…

a16663f

…ver`

Ref: Kitware#877 (comment)
Ref: Kitware#877 (comment)

UlysseDurand force-pushed the docs-tutoriel-vue3 branch from 35770e6 to a16663f Compare

May 13, 2026 08:21

Contributor Author

UlysseDurand commented May 13, 2026

My mistake, I didn't really understand what a rebase was, it should now show no conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet