break exception context cycle from BaseExceptionGroup in middleware#3341
Open
balochy wants to merge 1 commit into
Open
break exception context cycle from BaseExceptionGroup in middleware#3341balochy wants to merge 1 commit into
balochy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
BaseHTTPMiddlewarecatches a route exception, anyio wraps it in aBaseExceptionGroup.create_collapsing_task_groupextracts the single exception and re-raises it — but does so inside theexceptذbock.Python implicitly sets
exc.__context__to the caught BaseExceptionGroup which containsexcitself, creating a reference cycle:exc.context → BaseExceptionGroup → BaseExceptionGroup.exceptions[0] → exc
Traceback formatters (e.g. Rich) following the
__context__chain hit infinite recursion when middleware is present.Fix by raising outside the
exceptblock so Python does not overwrite__context__with the BaseExceptionGroup. Also add the missing__suppress_context__guard incall_nextso suppressed contexts are not incorrectly promoted to cause.please see discussion: #2942
Checklist