add resume upload button #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-sage
force-pushed
the
blade/add-resume-button-member-form
branch
2 times, most recently
from
c00f434 to
714b191
Compare
Contributor
|
looks fire, think we can get a video demo attached? |
DVidal1205
requested changes
Jan 3, 2025
Contributor
There was a problem hiding this comment.
heat asf, ive only got one small review i can see but be sure to wait for 1 more review.
also, can we extract the button and all of its logic into a component? we will need to use this exact button on @TTRAN70's new member management front end, so that may help a lot to use later and you know the functionality.
apps/blade/src/app/member/application/_components/member-application-form.tsx
Show resolved
Hide resolved
must108
requested changes
Jan 3, 2025
apps/blade/src/app/member/application/_components/member-application-form.tsx
Outdated
Show resolved
Hide resolved
| } else { | ||
| ctx.addIssue({ | ||
| code: z.ZodIssueCode.custom, | ||
| message: "Object in FileList is undefined", |
Member
There was a problem hiding this comment.
this and other zod issues/errors/not user-facing strings can have more consistent punctuation
Lewin-B
force-pushed
the
blade/add-resume-button-member-form
branch
from
387e586 to
548e907
Compare
DVidal1205
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
- 0 or 1 files attached.
- PDF required.
- File size is maximum 5MB.
Test Plan
New frontend input for resume in the member application:
Manual testing process for the upload resume route: