Skip to content

Open Files, Command Output, and Notifications Updates - #3672

Open
ssigwart wants to merge 1 commit into
Komodo:masterfrom
ssigwart:panes
Open

Open Files, Command Output, and Notifications Updates#3672
ssigwart wants to merge 1 commit into
Komodo:masterfrom
ssigwart:panes

Conversation

@ssigwart

@ssigwart ssigwart commented Feb 4, 2019

Copy link
Copy Markdown
Contributor
  • Filter option for open files.
  • Comment output clear option.
  • Notifications clear option.

@ssigwart
Open Files, Command Output, and Notifications updates.
5956109 
- Filter option for open files
- Comment output clear option
- Notifications clear option
@Naatan

Naatan commented Feb 5, 2019

Copy link
Copy Markdown
Member

Hey @ssigwart ! This is awesome, really appreciate the work here! But could you please submit these as separate PRs? You're doing 3 wildly different things all in one PR. Makes it hard to review each in their own merit, since we're not just reviewing the code, we're also reviewing feature implications.

@Naatan
Naatan requested a review from th3coop February 5, 2019 16:57
@ssigwart

ssigwart commented Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

I split them up. I didn't know if you'd want 4 PRs in a day.

This was referenced Feb 5, 2019
Open
Open
Merged
@th3coop

th3coop commented Feb 5, 2019

Copy link
Copy Markdown
Member

I didn't know if you'd want 4 PRs in a day.

We loves PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@th3coop th3coop Awaiting requested review from th3coop

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ssigwart @Naatan @th3coop