GH-28: [MOVE] GztProcessor #34

vibhatha · 2026-01-22T05:39:29Z

No description provided.

…actions

…nder one parent

…rt snapshot

…routes

…iple gazettes released on the same date

…ew adds

… or department names during move operations.

…nes are present

…are present when a new gazette is added.

…edone due to earlier changes.

…omitted transactions

…azette number.

…along with transactions

… draft gazettes.

Implement user interface for org gazette processing

…35be21edafe' git-subtree-dir: gazettes/preprocess git-subtree-mainline: 9135ef1 git-subtree-split: c489978

gemini-code-assist · 2026-01-22T05:40:52Z

Summary of Changes

Hello @vibhatha, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a comprehensive solution for processing and managing Sri Lankan government gazette data. It establishes a new directory gazettes/preprocess containing a Python FastAPI backend responsible for parsing gazette JSON inputs, identifying organizational changes (ministry/department structure, person-portfolio assignments), maintaining a versioned state in SQLite databases, and generating CSV outputs. Complementing this, a React frontend provides an intuitive interface for users to interact with the system, visualize the organizational state, review predicted transactions, and commit updates, enhancing the overall data management workflow.

Highlights

New Full-Stack Application: This pull request introduces a complete web application for processing Sri Lankan government gazette data, featuring a Python FastAPI backend and a React frontend.
Gazette Processing Logic: The Python backend (gztprocessor) is designed to extract, classify, and manage structural changes from gazettes, covering both Ministry/Department (MinDep) and Person-Portfolio assignments.
Versioned State Management: A SQLite-based system is implemented to maintain versioned snapshots of the organizational state, enabling historical tracking and potential rollback capabilities for gazette changes.
Interactive Frontend Interface: A user-friendly React frontend (gztp-frontend) provides an intuitive interface for users to visualize the current organizational state, add new gazettes, preview detected transactions (adds, moves, terminates, renames), and approve/commit changes.
Automated CSV Output Generation: The system automatically generates structured CSV files for all detected transactions, facilitating seamless integration with graph databases like Neo4j for further analysis and visualization.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces the GztProcessor application, a comprehensive system with a Python FastAPI backend and a React frontend for processing and managing gazette data. The changes are extensive, adding the entire application structure, including database handlers, state managers, API routes, and UI components. My review focuses on critical areas for improvement, such as configuration management, adherence to React best practices, and backend correctness. Key issues identified include hardcoded URLs and CORS origins which will hinder deployment, improper database initialization in the FastAPI application, and some non-idiomatic React patterns that affect maintainability and performance. Addressing these points will significantly improve the robustness and scalability of the new application.

gemini-code-assist · 2026-01-22T05:43:34Z

gazettes/preprocess/gztp-frontend/src/AddGazette.jsx

+    const handleSubmit = async () => {
+        if (!gazetteNumber || !gazetteDate || !gazetteType) return;
+
+        const endpoint = `http://localhost:8000/mindep/${gazetteType === 'initial' ? 'initial' : 'amendment'}/${gazetteDate}/${gazetteNumber}`;


The API endpoint URL is hardcoded. This makes the application difficult to deploy to different environments (e.g., staging, production), as the URL will need to be manually changed. It's a best practice to use environment variables for such configurations. You can create a .env file in your frontend's root directory and access variables from it using import.meta.env.VITE_API_BASE_URL.

This issue is also present in other components, such as StateTable.jsx and TransactionPreview.jsx.

Suggested change

const endpoint = `http://localhost:8000/mindep/${gazetteType === 'initial' ? 'initial' : 'amendment'}/${gazetteDate}/${gazetteNumber}`;

const endpoint = `${import.meta.env.VITE_API_BASE_URL || 'http://localhost:8000'}/mindep/${gazetteType === 'initial' ? 'initial' : 'amendment'}/${gazetteDate}/${gazetteNumber}`;

gemini-code-assist · 2026-01-22T05:43:34Z

gazettes/preprocess/main.py

+app.include_router(transaction_router)
+app.add_middleware(
+    CORSMiddleware,
+    allow_origins=["http://localhost:5173"], 


The CORS allow_origins is hardcoded to http://localhost:5173. This will prevent the frontend from connecting to the API in any environment other than local development (e.g., staging, production). This value should be configured through environment variables to allow for flexibility across different deployment environments.

gemini-code-assist · 2026-01-22T05:43:35Z

gazettes/preprocess/gztp-frontend/src/StateTable.jsx

+    const handleGazetteCommitted = (committedIndex) => {
+        setGazetteWarnings((prev) => {
+            const gazettes = data.presidents[selectedPresidentIndex]?.gazettes || [];
+            const newWarnings = prev.slice();
+
+            // Clear warning on committed gazette
+            newWarnings[committedIndex] = false;
+
+            // Persist updated warning to drafts table
+            const committedGazette = gazettes[committedIndex];
+            axios.post(
+                `http://localhost:8000/transactions/${committedGazette.number}/warning`,
+                { warning: false }
+            ).catch(err => console.error("Failed to update warning:", err));
+
+            // Mark all gazettes after committedIndex as needing redo
+            for (let i = committedIndex + 1; i < gazettes.length; i++) {
+                newWarnings[i] = true;
+
+                // Persist warning to drafts table
+                axios.post(
+                    `http://localhost:8000/transactions/${gazettes[i].number}/warning`,
+                    { warning: true }
+                ).catch(err => console.error("Failed to update warning:", err));
+            }
+
+            return newWarnings;
+        });
+    };


This function triggers API calls (axios.post) inside the setGazetteWarnings state updater function. State updater functions in React should be pure and must not contain side effects. This pattern can lead to unpredictable behavior, race conditions, and makes the component difficult to test and debug.

The side effects (API calls) should be moved out of the state updater. You can either place them in a useEffect hook that triggers when the relevant state changes, or handle them in a separate async function that subsequently calls the state setters.

gemini-code-assist · 2026-01-22T05:43:35Z

gazettes/preprocess/main.py

+if __name__ == "__main__":
+    init_gov_db()
+    init_person_db()
+    init_transaction_db()
+    print("✅ Databases initialized.")


The database initialization logic is placed within an if __name__ == "__main__": block. This block is not executed when the application is run by a production server like Uvicorn, which imports the app object directly. This will cause the application to fail at runtime because the databases are not initialized.

This logic should be moved to a FastAPI lifespan context manager, which is the modern and recommended way to handle startup and shutdown events.

gemini-code-assist · 2026-01-22T05:43:35Z

gazettes/preprocess/gztp-frontend/src/AddGazette.jsx

+                alert(response.data.error); // show the error from backend
+                return;
+            }
+            if (gazetteType == 'initial') {


Using the loose equality operator == can lead to unexpected bugs due to type coercion. It is a best practice to always use the strict equality operator === to ensure both value and type are compared.

Suggested change

if (gazetteType == 'initial') {

if (gazetteType === 'initial') {

gemini-code-assist · 2026-01-22T05:43:35Z

gazettes/preprocess/gztp-frontend/src/TransactionPreview.jsx

+    const handleMinisterNameChange = (index, newName) => {
+        const updatedData = JSON.parse(JSON.stringify(data));
+        updatedData.presidents[selectedPresidentIndex].gazettes[selectedGazetteIndex].transactions[index].name = newName;
+        setData(updatedData);
+    };


Throughout this component, JSON.parse(JSON.stringify(data)) is used to create a deep copy of the entire data object for every small state update. This is inefficient, especially for large state objects, and is not an idiomatic React pattern. It forces React to re-render more of the component tree than necessary.

It's better to use immutable update patterns with the spread syntax to update only the necessary parts of the state tree. This is more performant and aligns with React's best practices.

gemini-code-assist · 2026-01-22T05:43:35Z

gazettes/preprocess/gztprocessor/csv_writer.py

+                move_rows.append({
+                    "transaction_id": transaction_id,
+                    "old_parent": prev_min,
+                    "new_parent": minister["name"],
+                    "child": dept_name,
+                    "type": "AS_DEPARTMENT",
+                    "date": date_str
+                })


The move_rows are generated with a key named type. However, in generate_amendment_csvs, the equivalent field is named rel_type. This inconsistency will create CSV files with different headers for the same kind of data, which will likely break any downstream processing logic. For consistency, this should be changed to rel_type.

Suggested change

move_rows.append({

"transaction_id": transaction_id,

"old_parent": prev_min,

"new_parent": minister["name"],

"child": dept_name,

"type": "AS_DEPARTMENT",

"date": date_str

})

move_rows.append({

"transaction_id": transaction_id,

"old_parent": prev_min,

"new_parent": minister["name"],

"child": dept_name,

"rel_type": "AS_DEPARTMENT",

"date": date_str

})

gemini-code-assist · 2026-01-22T05:43:35Z

gazettes/preprocess/gztprocessor/csv_writer.py

+            writer = csv.DictWriter(f, fieldnames=[
+                "transaction_id", "old_parent", "new_parent", "child", "type", "date"
+            ])


To align with the suggested change for generating move_rows and to maintain consistency with generate_amendment_csvs, the header field type should be renamed to rel_type.

Suggested change

writer = csv.DictWriter(f, fieldnames=[

"transaction_id", "old_parent", "new_parent", "child", "type", "date"

])

writer = csv.DictWriter(f, fieldnames=[

"transaction_id", "old_parent", "new_parent", "child", "rel_type", "date"

])

sehansi-9 and others added 30 commits June 30, 2025 16:03

initial commit

6bfe758

add get latest state content route

31012b5

add endpoint to create first state from tabular data

8f713d6

refactor the database and state generation for initial tabular data

b35b9f8

add json processing and move transaction detector

03d9000

implement move detection for a fixed structure of inputs

9ad8a8d

extract the positions for ADDs and include them in ADD and MOVE trans…

a913cf7

…actions

fix: fix bug in identifying a MOVE when multiple inserts are listed u…

84d4fb6

…nder one parent

apply the identified transactions to the current state in db and expo…

78218a7

…rt snapshot

improve modular separation between db and state files management and …

35b2543

…routes

update POST endpoints to accept request body payload

f18def5

improved routes to get states

7f520d0

test with two sample amendment files

7b47509

add the sample payloads and readme

ab726b7

refactor the whole codebase to accept gazette numbers to process mult…

39ba873

…iple gazettes released on the same date

add csv generation for initial and amendment gazettes

0232a73

change the input file's date format to hypernated form

ecc5f0f

fix: add and terminate csv formats and date format

54c6081

refactor: restructure project directories

f78ff95

fix: fix the bug in reading input file's date format

0223726

add database and sample gazette data for persons

63963b5

Initial commit

ee69043

Merge remote-tracking branch 'gdp/main'

a06bf1a

fix missing util file

73e81ea

update readme

0d31ea3

refactor: extract shared state logic to AbstractStateManager base class

246d7e8

refactor: centralize state routes

0bd7e9e

add person router structure

4e5ca8d

change structure of payloads for mindep amendments

031ed7e

add fuzzy search to suggest similar entries from previous state for n…

a06511a

…ew adds

sehansi-9 and others added 28 commits August 11, 2025 09:54

functionality to add and remove ministers and handling empty minister…

bd608e8

… or department names during move operations.

add collapsible sections for minister departments

dcb72ce

Add functionality to allow adding departments even when no existing o…

e40fa49

…nes are present

remove the check for minimum departments before allowing deletion

f9495c0

add move removal functionality and UI enhancements

24d6009

add gazette warning management on commit action

aacf7b5

implement logic to append a warning if any existing gazette warnings …

bb9ab10

…are present when a new gazette is added.

Enhance transaction preview and table loading states

94f7518

functionality to refetch latest state

3e76369

Implement an error icon to visually indicate that a gazette must be r…

3d3dc2d

…edone due to earlier changes.

Add a new transaction database to store gazette info and uncomitted/c…

31eafe9

…omitted transactions

Implement endpoints to save and load transactions associated with a g…

5a1e0ac

…azette number.

Support save and refetch actions for transactions

2d5dcf5

change initial state of expanded ministers to be collapsed by default.

f070aa7

enhance the transaction saving and fetching process to include moves …

537305b

…along with transactions

Updates the gazette fetching logic to separately handle committed and…

2293ff9

… draft gazettes.

update gazette commitment handling in transaction preview

14bded7

store and fetch the warning status from db

2f6cfa8

refactor for amendment display

38d881b

modularize and set up preview for amendments

12df8af

refreshing and fetching for amendments

fd30d3d

implement approve commits for amendments

d5996e7

fix bug in displaying previous ministries

a967831

improve error handling for gazette types

8fa0356

update readme

5bd217a

update readme

de1b42b

Merge pull request LDFLK#7 from sehansi-9/main

c489978

Implement user interface for org gazette processing

Add 'gazettes/preprocess/' from commit 'c489978d96747b1d29ef2ab3cf6d4…

49899cf

…35be21edafe' git-subtree-dir: gazettes/preprocess git-subtree-mainline: 9135ef1 git-subtree-split: c489978

gemini-code-assist bot reviewed Jan 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-28: [MOVE] GztProcessor #34

GH-28: [MOVE] GztProcessor #34

Uh oh!

vibhatha commented Jan 22, 2026

Uh oh!

gemini-code-assist bot commented Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

gemini-code-assist bot Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const endpoint = `http://localhost:8000/mindep/${gazetteType === 'initial' ? 'initial' : 'amendment'}/${gazetteDate}/${gazetteNumber}`;
	const endpoint = `${import.meta.env.VITE_API_BASE_URL \|\| 'http://localhost:8000'}/mindep/${gazetteType === 'initial' ? 'initial' : 'amendment'}/${gazetteDate}/${gazetteNumber}`;

	if (gazetteType == 'initial') {
	if (gazetteType === 'initial') {

GH-28: [MOVE] GztProcessor #34

Are you sure you want to change the base?

GH-28: [MOVE] GztProcessor #34

Uh oh!

Conversation

vibhatha commented Jan 22, 2026

Uh oh!

gemini-code-assist bot commented Jan 22, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants