fix(prover-ray): adding limit checks for the lookups and permutations - #3619
Open
bogdanbear wants to merge 12 commits into
Open
fix(prover-ray): adding limit checks for the lookups and permutations#3619bogdanbear wants to merge 12 commits into
bogdanbear wants to merge 12 commits into
Conversation
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
bogdanbear
added
the
Prover-RAY
bogdanbear
changed the title
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
bogdanbear
marked this pull request as ready for review
July 24, 2026 03:44
…ould not be exported Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
Signed-off-by: Bogdan Ursu <bogdanursuoffice@gmail.com>
ThomasPiellard
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds per-query row-limit checks to the lookup (lookuptologderivsum) and permutation (grandproduct) compilers, guarding against small-field accumulator overflow: each check runs as both a prover action (panics) and a verifier action (rejects), registered on the witness round so it fires before any rows are walked.
Introduces the budget primitives in wiop: MaxLookupRows (2^30) and MaxPermutationRows (2^58), enforced via TableRelationQuery.CheckRowLimit / ValidateRowLimit, which bound each side of a query independently.
Establishes how the budget is shared: lookups sharing an including (B) table drain one common accumulator, so their limit is divided by the group's lookup count; permutations and message-bus handles use independent per-module accumulators, so their full budget applies per query/handle.
Checklist