refactor(container + bm): use Arc<str> and WsElementId for Workspace Element IDs#1489
Open
JustForFun88 wants to merge 2 commits intoLGUG2Z:masterfrom
Open
refactor(container + bm): use Arc<str> and WsElementId for Workspace Element IDs#1489JustForFun88 wants to merge 2 commits intoLGUG2Z:masterfrom
Arc<str> and WsElementId for Workspace Element IDs#1489JustForFun88 wants to merge 2 commits intoLGUG2Z:masterfrom
Conversation
JustForFun88
force-pushed
the
use_id_istead_of_str
branch
from
20d8b8b to
01cdc38
Compare
JustForFun88
force-pushed
the
use_id_istead_of_str
branch
from
89f7de0 to
d7158ee
Compare
JustForFun88
changed the title
Arc<str> and WsElementId for Workspace Element IDsContainerId for Container and WsElementId for Workspace Element IDs
JustForFun88
force-pushed
the
use_id_istead_of_str
branch
from
d7158ee to
c279917
Compare
JustForFun88
changed the title
ContainerId for Container and WsElementId for Workspace Element IDsArc<str> and WsElementId for Workspace Element IDs
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
07b6367 to
b613986
Compare
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
58c86b3 to
c165172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request switches to
Arc<str>for container IDs and replaces plain strings with theWsElementIdenum for workspace elements in theBorderstructure.Motivation
StringwithArc<str>for container IDs makes all cloning cheap.WsElementIdenum eliminates heap allocation for floating window IDs in theBorderstructure.Benefits
Notes
Deserialization from legacy JSON (string IDs) is preserved by custom (de)serializers.