refactor (window): Lazy, Single-pass Evaluation of Window Properties and Efficient Rule Matching#1495
Open
JustForFun88 wants to merge 6 commits intoLGUG2Z:masterfrom
Open
refactor (window): Lazy, Single-pass Evaluation of Window Properties and Efficient Rule Matching#1495JustForFun88 wants to merge 6 commits intoLGUG2Z:masterfrom
JustForFun88 wants to merge 6 commits intoLGUG2Z:masterfrom
Conversation
Add new IDs to distinguish different structures
1febb74 to
89ddc9b
Compare
89ddc9b to
796e928
Compare
07b6367 to
b613986
Compare
58c86b3 to
c165172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is based on #1494.
This PR brings a major internal cleanup to window matching and rule evaluation. It not only minimizes code, but also removes wasteful allocations and short-circuits at the first failure during composite rule checks.
Main improvements
Lazy evaluation of window properties:
Previously, all
Windowproperties (title,exe,class,path) were computed up front even if only one was actually needed by the rules. Now, each property is computed on demand—when the rule requires it—and never more than once per matching operation.For example, code like:
is now:
Elimination of unnecessary allocations for composite rules:
Previously, evaluating
MatchingRule::Compositecollected all results in aVecbefore checking if they were all true. Now, evaluation is fully short-circuiting and allocation-free:Smaller codebase. All boilerplate removed.