refactor(ring): use MonitorIdx, WorkspaceIdx, ContainerIdx, WindowIdx instead of usize#1500
Draft
JustForFun88 wants to merge 8 commits intoLGUG2Z:masterfrom
Draft
refactor(ring): use MonitorIdx, WorkspaceIdx, ContainerIdx, WindowIdx instead of usize#1500JustForFun88 wants to merge 8 commits intoLGUG2Z:masterfrom
JustForFun88 wants to merge 8 commits intoLGUG2Z:masterfrom
Conversation
Add new IDs to distinguish different structures
Owner
|
I'm gonna comment on this one, but this applies to all of the recent refactoring PRs I don't think most of these will be considered for merging - I have a lot going on in my life right now, and I think the only other of these refactor PRs that I am considering merging is the one which breaks up the komorebi bar's komorebi widget I appreciate the effort, and I'm happy for you to keep working on this as a practical learning exercise, but I want to be transparent that there is a low likelihood of these changes you are working on being merged upstream |
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
07b6367 to
b613986
Compare
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
58c86b3 to
c165172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.