Open
Conversation
LGUG2Z
reviewed
Jul 24, 2025
| Err(_) => return None, | ||
| }; | ||
|
|
||
| let mut found: Vec<(usize, &Monitor)> = Vec::new(); |
Owner
There was a problem hiding this comment.
Let's declare something like let mut target_idx = None here, and then below replace all the returns with target_idx = Some(whatever_index), and then finally replace the None returned at the end with target_idx
Owner
|
This looks good, I just left a small refactor request to reduce the number of early returns added to this function Once you amend your commit with those changes, make sure you also match the commit message style (ie. |
07b6367 to
b613986
Compare
58c86b3 to
c165172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: If more than one monitor is eligible to move to, the behavior is undefined.
Solution: In WindowManager::monitor_idx_in_direction, added logic to handle multiple candidate monitors. When more than one monitor is found, the method now checks the top-left corner of the currently focused window to determine the appropriate monitor. If this check fails, it falls back to the first detected monitor.
P.S. This is my first time using Rust and contributing to a repository — please let me know if I’ve done anything incorrectly or if there’s anything I can improve! :)