Skip to content

Tqz/somoclu pipe#69

Open
ztq1996 wants to merge 6 commits intomainfrom
tqz/somoclu_pipe
Open

Tqz/somoclu pipe#69
ztq1996 wants to merge 6 commits intomainfrom
tqz/somoclu_pipe

Conversation

@ztq1996
Copy link
Contributor

@ztq1996 ztq1996 commented Mar 18, 2026

Problem & Solution Description (including issue #)

Create a somoclu pipeline and notebook that lets you train a SOM and estimate the n(z) of another catalog based on a calibration catalog

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link
Contributor

@hangqianjun hangqianjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though unit test needs some fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants