Access multiple ANC350s simultaneously.#2
Open
jacione wants to merge 1 commit intoLaukei:masterfrom
Open
Conversation
…ly in v4. PyANC350v4.py - Moved Positioner.discover() outside the Positioner class to be its own function. - Added a Positioner.__del__() method for safer garbage collection. - Removed unused imports. ANC350libv4.py - Made the DLL import more concise with pathlib instead of os. - Removed unused imports. example-v4.py - Refactored to match above changes. Also, my IDE made a few changes to adhere to current PEP8 convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working with v4 and made some edits to the code so that it can address multiple controllers at the same time. It seems like a useful thing, so I figured I'd share it.
PyANC350v4.py
Positioner.discover()outside thePositionerclass to be its own function.Positioner.__del__()method for safer garbage collection.ANC350libv4.py
pathlibinstead ofos.example-v4.py
Also, my IDE made a few changes to adhere to current PEP8 convention.