✨ (signer-polkadot) [LIVE-30995]: Implement APDU commands for the Polkadot signer by cted-ledger · Pull Request #1530 · LedgerHQ/device-sdk-ts

cted-ledger · 2026-06-02T16:36:28Z

📝 Description

Implement the full APDU command layer for the signer-polkadot DMK signer kit. The signer is generic across the Polkadot family (Polkadot, Westend, AssetHub, Bittensor, …) — chains differ only by the SS58 prefix parameter and the derivation path. Bittensor is the driving integration.

Commands implemented:

GetAddressCommand — derives the address with a configurable SS58 prefix (0 = Polkadot, 42 = Bittensor) and optional on-device confirmation
SignTransactionCommand — multi-chunk protocol (INIT/ADD/LAST) for signing transaction blobs, with the derivation path and blob length sent in the initial chunk
SignTransactionTask — orchestrates blob+metadata chunking into sequential APDU calls, respecting the 255-byte payload limit

Supporting utilities:

EncodeDerivationPath — encodes a hardened BIP44 path into the little-endian binary layout expected by the device app
polkadotApplicationErrors — maps device status words to typed error codes
Constants module with the app-wide CLA (INS/P2 live in their respective commands)

❓ Context

JIRA or GitHub link: LIVE-30995
Feature: Polkadot-family signer kit (APDU layer) — driven by the Bittensor integration

Depends on #1501 (scaffold, merged).

✅ Checklist

Covered by automatic tests — unit tests across the command, task, use-case and signer layers (GetAddress/SignTransaction commands, SignTransactionTask, EncodeDerivationPath, application errors, GetAddressUseCase, DefaultSignerPolkadot, builder)
Changeset is provided
Documentation is up-to-date
Impact of the changes:
- New APDU commands in @ledgerhq/device-signer-kit-polkadot
- No impact on existing packages — all changes scoped to signer-polkadot
- Multi-chunk signing protocol for large Substrate extrinsics

vercel · 2026-06-02T16:36:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
device-sdk-ts-sample	Ready	Preview, Comment	Jul 8, 2026 8:27am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
doc-device-management-kit	Ignored		Jul 8, 2026 8:27am

github-actions · 2026-06-02T16:39:43Z

Danger Check Results

Messages

✅	Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against df12d8d

Copilot

Pull request overview

Implements the Polkadot/Bittensor signer-kit APDU command layer in @ledgerhq/device-signer-kit-polkadot, including address derivation (SS58 prefix) and multi-APDU transaction signing orchestration.

Changes:

Added concrete APDU implementations for GetAddressCommand and SignTransactionCommand (INIT/ADD/LAST) plus SignTransactionTask chunking logic.
Introduced Polkadot app error mapping + derivation-path binary encoding utility.
Wired logger factory into the package DI and app-binder, and added comprehensive Vitest coverage + changeset.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/signer/signer-polkadot/src/internal/externalTypes.ts	Adds DI token for DMK logger factory.
packages/signer/signer-polkadot/src/internal/di.ts	Binds `DmkLoggerFactory` to DMK logger factory implementation.
packages/signer/signer-polkadot/src/internal/app-binder/task/SignTransactionTask.ts	Implements multi-chunk signing task using `APDU_MAX_PAYLOAD` and INIT/ADD/LAST phases.
packages/signer/signer-polkadot/src/internal/app-binder/task/SignTransactionTask.test.ts	Tests for chunking behavior and error handling in signing task.
packages/signer/signer-polkadot/src/internal/app-binder/PolkadotAppBinder.ts	Injects logger factory and forwards loggers to device actions and signing task.
packages/signer/signer-polkadot/src/internal/app-binder/constants.ts	Adds P2 constants (curve selection) for APDU headers.
packages/signer/signer-polkadot/src/internal/app-binder/command/utils/polkadotApplicationErrors.ts	Introduces Polkadot app status-word mapping and typed command error class.
packages/signer/signer-polkadot/src/internal/app-binder/command/utils/PolkadotApplicationErrors.test.ts	Tests Polkadot app error mapping and error class construction.
packages/signer/signer-polkadot/src/internal/app-binder/command/utils/EncodeDerivationPath.ts	Adds derivation path encoder (5×u32 LE) for Polkadot app format.
packages/signer/signer-polkadot/src/internal/app-binder/command/utils/EncodeDerivationPath.test.ts	Tests derivation path encoding output and validation.
packages/signer/signer-polkadot/src/internal/app-binder/command/SignTransactionCommand.ts	Implements APDU building + response parsing for signing protocol.
packages/signer/signer-polkadot/src/internal/app-binder/command/SignTransactionCommand.test.ts	Tests APDU construction and status-word error handling for signing command.
packages/signer/signer-polkadot/src/internal/app-binder/command/GetAddressCommand.ts	Implements APDU building + response parsing for publicKey+address derivation.
packages/signer/signer-polkadot/src/internal/app-binder/command/GetAddressCommand.test.ts	Tests APDU construction and parsing for address command.
.changeset/bittensor-apdu-commands.md	Publishes a minor changeset for the new APDU layer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonarqubecloud · 2026-06-02T20:24:07Z

Quality Gate failed

Failed conditions
71.6% Coverage on New Code (required ≥ 80%)
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

mbertin-ledger

Please Handle also comment from sonarcloud analysis

mbertin-ledger · 2026-06-04T10:03:14Z

  SIGN_RAW: 0x03,
 } as const;
+
+export const P2 = {


[SHOULD] P2 is parameter for a given command, this should be directly in command SignTransactionCommand as it's used there.

Same for INS above.

Done in 251691e — moved the command-specific INS and P2 into GetAddressCommand and SignTransactionCommand; constants.ts now keeps only the app-wide LEDGER_CLA (also dropped the unused SIGN_RAW/ECDSA).

Complete the how-to-create-signer §13.1 test set (DefaultSignerPolkadot, GetAddressUseCase). Also fix a stale derivation-path example in the EncodeDerivationPath comment (354, generic Polkadot-family).

…ation) - Move command-specific INS/P2 into GetAddressCommand and SignTransactionCommand; keep only the app-wide CLA in constants (removes the unused SIGN_RAW/ECDSA). (mbertin) - Validate ss58Prefix and blobLength fit in a uint16 before the little-endian encoding, instead of silently truncating. (copilot) - Use the reused Polkadot path (354) in test fixtures and rename BITTENSOR_PATH -> POLKADOT_PATH (the signer is generic, not Bittensor-specific).

Rename and reword the changeset so the released changelog describes the Polkadot-family signer rather than a Bittensor-specific feature (the signer is generic; chains differ only by SS58 prefix).

sonarqubecloud · 2026-07-08T08:49:02Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.4% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot AI review requested due to automatic review settings June 2, 2026 16:36

cted-ledger requested a review from a team as a code owner June 2, 2026 16:36

Copilot started reviewing on behalf of cted-ledger June 2, 2026 16:36 View session

github-actions Bot assigned cted-ledger Jun 2, 2026

Copilot AI reviewed Jun 2, 2026

View reviewed changes

cted-ledger force-pushed the feat/LIVE-30995-implement-apdu-polkadot-signer branch from 96dd06d to 7c180a0 Compare June 2, 2026 19:52

vercel Bot deployed to Preview – device-sdk-ts-sample June 2, 2026 19:54 View deployment

cted-ledger force-pushed the feat/LIVE-30995-implement-apdu-polkadot-signer branch from 7c180a0 to 1e8eca9 Compare June 2, 2026 20:08

vercel Bot deployed to Preview – device-sdk-ts-sample June 2, 2026 20:10 View deployment

mbertin-ledger requested changes Jun 4, 2026

View reviewed changes

cted-ledger marked this pull request as draft June 11, 2026 07:54

cted-ledger force-pushed the feat/LIVE-30995-implement-apdu-polkadot-signer branch from 1e8eca9 to b533fe9 Compare July 7, 2026 14:04

vercel Bot deployed to Preview – device-sdk-ts-sample July 7, 2026 14:07 View deployment

vercel Bot deployed to Preview – device-sdk-ts-sample July 7, 2026 16:00 View deployment

vercel Bot deployed to Preview – device-sdk-ts-sample July 8, 2026 06:53 View deployment

cted-ledger changed the title ~~✨ (signer-polkadot) [LIVE-30995]: Implement APDU commands for Polkadot/Bittensor~~ ✨ (signer-polkadot) [LIVE-30995]: Implement APDU commands for the Polkadot signer Jul 8, 2026

vercel Bot deployed to Preview – device-sdk-ts-sample July 8, 2026 06:57 View deployment

cted-ledger added 4 commits July 8, 2026 10:25

✨ (signer-polkadot): Implement APDU commands for Polkadot/Bittensor

43b3c0f

✅ (signer-polkadot): Add DefaultSigner + GetAddressUseCase tests

f78fad1

Complete the how-to-create-signer §13.1 test set (DefaultSignerPolkadot, GetAddressUseCase). Also fix a stale derivation-path example in the EncodeDerivationPath comment (354, generic Polkadot-family).

🔧 (signer-polkadot): Make changeset generic (Polkadot-family)

df12d8d

Rename and reword the changeset so the released changelog describes the Polkadot-family signer rather than a Bittensor-specific feature (the signer is generic; chains differ only by SS58 prefix).

cted-ledger force-pushed the feat/LIVE-30995-implement-apdu-polkadot-signer branch from 0a6325c to df12d8d Compare July 8, 2026 08:25

vercel Bot deployed to Preview – device-sdk-ts-sample July 8, 2026 08:27 View deployment

cted-ledger marked this pull request as ready for review July 8, 2026 09:43

cted-ledger requested a review from mbertin-ledger July 8, 2026 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

✨ (signer-polkadot) [LIVE-30995]: Implement APDU commands for the Polkadot signer#1530

✨ (signer-polkadot) [LIVE-30995]: Implement APDU commands for the Polkadot signer#1530
cted-ledger wants to merge 4 commits into
developfrom
feat/LIVE-30995-implement-apdu-polkadot-signer

cted-ledger commented Jun 2, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 2, 2026

Uh oh!

mbertin-ledger left a comment

Uh oh!

mbertin-ledger Jun 4, 2026

Uh oh!

cted-ledger Jul 8, 2026

Uh oh!

sonarqubecloud Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

cted-ledger commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

❓ Context

✅ Checklist

Uh oh!

vercel Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Danger Check Results

Messages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 2, 2026

Quality Gate failed

Uh oh!

mbertin-ledger left a comment

Choose a reason for hiding this comment

Uh oh!

mbertin-ledger Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

cted-ledger Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 8, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cted-ledger commented Jun 2, 2026 •

edited

Loading

vercel Bot commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading