Skip to content

🎨 (signer-solana) [NO-ISSUE]: Rename web3check to transactionCheck#1576

Closed
fAnselmi-Ledger wants to merge 2 commits into
developfrom
chore/no-issue-web3checks-to-txcheck-rename
Closed

🎨 (signer-solana) [NO-ISSUE]: Rename web3check to transactionCheck#1576
fAnselmi-Ledger wants to merge 2 commits into
developfrom
chore/no-issue-web3checks-to-txcheck-rename

Conversation

@fAnselmi-Ledger

Copy link
Copy Markdown
Contributor

πŸ“ Description

Renamed all instances of web3checks into transactionCheck

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@fAnselmi-Ledger
fAnselmi-Ledger requested a review from a team as a code owner June 24, 2026 09:49
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
device-sdk-ts-sample Ready Ready Preview, Comment Jun 25, 2026 12:32pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
doc-device-management-kit Ignored Ignored Jun 25, 2026 12:32pm

Request Review

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Danger Check Results

Messages

βœ…

Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against c56eed9

@fAnselmi-Ledger fAnselmi-Ledger changed the title 🎨 (signer-solana): Rename web3check to transactionCheck 🎨 (signer-solana) [NO-ISSUE]: Rename web3check to transactionCheck Jun 24, 2026
@fAnselmi-Ledger
fAnselmi-Ledger force-pushed the feat/dsdk-1146-solana-clear-sign-device-action branch from 009e167 to abcfcc6 Compare June 24, 2026 09:56
@fAnselmi-Ledger
fAnselmi-Ledger force-pushed the chore/no-issue-web3checks-to-txcheck-rename branch from 31f1752 to 262aa5d Compare June 24, 2026 09:57
@fAnselmi-Ledger
fAnselmi-Ledger force-pushed the chore/no-issue-web3checks-to-txcheck-rename branch from 262aa5d to 4cfc47e Compare June 24, 2026 10:34
@fAnselmi-Ledger
fAnselmi-Ledger force-pushed the feat/dsdk-1146-solana-clear-sign-device-action branch from abcfcc6 to ddf595c Compare June 25, 2026 09:14
@fAnselmi-Ledger
fAnselmi-Ledger force-pushed the feat/dsdk-1146-solana-clear-sign-device-action branch from ddf595c to 84dcc31 Compare June 25, 2026 10:03

@aussedatlo aussedatlo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@sonarqubecloud

Copy link
Copy Markdown

@fAnselmi-Ledger
fAnselmi-Ledger force-pushed the feat/dsdk-1146-solana-clear-sign-device-action branch from 84dcc31 to 274dac3 Compare June 25, 2026 13:00
Base automatically changed from feat/dsdk-1146-solana-clear-sign-device-action to feat/dsdk-1146-generic-clear-sign-providers June 25, 2026 14:18
Base automatically changed from feat/dsdk-1146-generic-clear-sign-providers to develop June 25, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants