Alex+Ryan/Add Lockout Period #563
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,38 +2,40 @@ | |
| // Licensed under the MIT License. | ||
|
|
||
| 'use client'; | ||
| import { AlertVariants } from '@/components/AlertNotification/Alerts.enum'; | ||
| import { ChevronLeft } from 'lucide-react'; | ||
| import { cn, getNFLTeamLogo } from '@/utils/utils'; | ||
| import { Control, FormProvider, useForm } from 'react-hook-form'; | ||
| import { | ||
| FormControl, | ||
| FormField, | ||
| FormItem, | ||
| FormMessage, | ||
| } from '@/components/Form/Form'; | ||
| import { | ||
| getAllWeeklyPicks, | ||
| getCurrentLeague, | ||
| getCurrentUserEntries, | ||
| getGameWeek, | ||
| } from '@/api/apiFunctions'; | ||
| import { ILeague } from '@/api/apiFunctions.interface'; | ||
| import { ISchedule } from './WeekTeams.interface'; | ||
| import { IWeekProps } from './Week.interface'; | ||
| import { NFLTeams } from '@/api/apiFunctions.enum'; | ||
| import { onWeeklyPickChange } from './WeekHelper'; | ||
| import { useAuthContext } from '@/context/AuthContextProvider'; | ||
| import { useDataStore } from '@/store/dataStore'; | ||
| import { useRouter } from 'next/navigation'; | ||
| import { z } from 'zod'; | ||
| import { zodResolver } from '@hookform/resolvers/zod'; | ||
| import Alert from '@/components/AlertNotification/AlertNotification'; | ||
| import GlobalSpinner from '@/components/GlobalSpinner/GlobalSpinner'; | ||
| import Image from 'next/image'; | ||
| import LinkCustom from '@/components/LinkCustom/LinkCustom'; | ||
| import React, { JSX, useEffect, useState } from 'react'; | ||
| import toast from 'react-hot-toast'; | ||
| import useIsUserLockedOut from '@/hooks/useIsUserLockedOut'; | ||
| import WeekTeams from './WeekTeams'; | ||
|
|
||
| /** | ||
| * Renders the weekly picks page. | ||
|
|
@@ -54,6 +56,7 @@ const Week = ({ entry, league, NFLTeams, week }: IWeekProps): JSX.Element => { | |
| useDataStore((state) => state); | ||
| const { isSignedIn } = useAuthContext(); | ||
| const router = useRouter(); | ||
| const lockedOut = useIsUserLockedOut(); | ||
|
|
||
| /** | ||
| * Fetches the current game week. | ||
|
|
@@ -217,9 +220,19 @@ const Week = ({ entry, league, NFLTeams, week }: IWeekProps): JSX.Element => { | |
| }; | ||
|
|
||
| try { | ||
| if (lockedOut) { | ||
|
Collaborator
There was a problem hiding this comment. I don't see any new unit tests for this.
Member
There was a problem hiding this comment. @shashilo can you elaborate what test exactly you're looking for?
Collaborator
There was a problem hiding this comment. It's a conditional statement, so you need to have a positive and negative unit tests for this. Checking that both conditions are accurate when their conditions are met. |
||
| toast.custom( | ||
| <Alert | ||
| variant={AlertVariants.Error} | ||
| message={`Team selection has been locked for the week!`} | ||
| />, | ||
| ); | ||
| } else { | ||
| await onWeeklyPickChange(params); | ||
| setUserPick(teamSelect); | ||
| router.push(`/league/${league}/entry/all`); | ||
| } | ||
|
choir241 marked this conversation as resolved.
|
||
| console.error(params); | ||
| } catch (error) { | ||
| console.error('Submission error:', error); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { renderHook } from '@testing-library/react'; | ||
| import useIsUserLockedOut from './useIsUserLockedOut'; | ||
|
|
||
| describe('useLockout hook', () => { | ||
| let getUTCDaySpy: jest.SpyInstance; | ||
| let getUTCHoursSpy: jest.SpyInstance; | ||
|
|
||
| beforeEach(() => { | ||
| getUTCDaySpy = jest.spyOn(Date.prototype, 'getUTCDay'); | ||
| getUTCHoursSpy = jest.spyOn(Date.prototype, 'getUTCHours'); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| getUTCDaySpy.mockRestore(); | ||
| getUTCHoursSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('should lock out on Saturday at 12am UTC', () => { | ||
| getUTCDaySpy.mockReturnValue(6); //Mocking Saturday | ||
| getUTCHoursSpy.mockReturnValue(0); //Mocking 12am UTC | ||
|
|
||
| const { result } = renderHook(() => useIsUserLockedOut()); | ||
|
|
||
| expect(result.current).toBe(true); | ||
| }); | ||
|
|
||
| it('should not be locked out on Wednesday at any time', () => { | ||
| getUTCDaySpy.mockReturnValue(3); //Mocking Wednesday | ||
| getUTCHoursSpy.mockReturnValue(12); //Mocking 12pm UTC | ||
|
|
||
| const { result } = renderHook(() => useIsUserLockedOut()); | ||
|
|
||
| expect(result.current).toBe(false); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to nest this if statement in the try block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. So what it does is run the api functions inside the try block. But, if its during the lockdown period it will block the api functions from running and instead run the toast notification. It is a way to stop hackers from hitting the api's when they shouldn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@braydoncoyer please let me know if you need more info on this
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexappleget @ryandotfurrer Yep, I get the purpose of the Try block. I think I was more asking if the try block could be moved inside the conditional to better represent which part of the code may cause/throw an error.
I'll leave this as a nit because as-is this likely works. However, I'm always a big fan of being more specific about which part of the code may need to have errors caught.