Migrate build system from cmake to meson#222
Open
ylabidi wants to merge 8 commits intoLibrum-Reader:mainfrom
Open
Migrate build system from cmake to meson#222ylabidi wants to merge 8 commits intoLibrum-Reader:mainfrom
ylabidi wants to merge 8 commits intoLibrum-Reader:mainfrom
Conversation
chore: move to meson as build system
chore: fix build to produce a working librum binary
…to-meson chore: finish migration from cmake to meson
…fline-mode-by-default feature: make the reader load in offline mode by default
Member
|
Thank you for this awesome PR. I really appreciate the effort you put into this. I don't use meson, so i won't merge this into the main branch, but I'd love to keep this version alive and create another branch for it. I won't be able to do this soon, but i'm going to leave this PR open until i get the chance. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is more of suggestion. If development direction and/or priorities aren't aligned with this proposal you can dismiss this pull request. I did this work to make Librum build and run smoothly on my machine (Linux) and thought it may be of use. This pull request effectively:
Build tested on Linux and a migration roadmap is added if this is of interest.