Fixing reconnect failure after pong Timeout#980
Merged
Links2004 merged 1 commit intoLinks2004:masterfrom Mar 21, 2026
Merged
Conversation
Issue: After a pong Timeout causes a client to disconnect, the client object becomes unuseable, causing subsequent reconnects to immediately trigger a disconnect. Fix: Reset the client's pongTimeoutCount to 0 upon client connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: After subsequent pong Timeouts cause a client to disconnect, the client object becomes unusable. Attempts to connect that try to use the client object result in pongTimeoutCount immediately triggering a disconnect.
Fix: Reset the client's pongTimeoutCount to 0 upon client connection