refactor(hm2): drop _64 encoder pins, keep 64-bit internal#3944
Open
grandixximo wants to merge 1 commit into
Open
refactor(hm2): drop _64 encoder pins, keep 64-bit internal#3944grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
Collaborator
|
sounds like this should be application of #3936 |
Contributor
Author
RFC LinuxCNC#3286 narrow option 1: fix float position wrap on high-count encoders via 64-bit internal counters, without exposing new HAL pin types. s32 count/rawcounts/rawlatch/ count-latched remain as truncated views of the internal 64-bit counters. Float position is computed from the full 64-bit value so it does not wrap. Avoids committing four integer pin types (s32/u32/s64/u64) into 2.10 ABI before the getter/setter direction in LinuxCNC#3286 is decided. The overflow fix from 8a3ac3f is preserved; only the pin exposure is reverted. Unused prev_event_rawcounts_64 dropped. BREAKING CHANGE: count_64, rawcounts_64, rawlatch_64 and count-latched_64 pins added post-2.9 are removed. HAL surface matches 2.9. Refs LinuxCNC#3286 LinuxCNC#2331
grandixximo
force-pushed
the
narrow-option-1-encoder
branch
2 times, most recently
from
3eae1ef to
2a0b291
Compare
Contributor
Author
Collaborator
|
It this a step on the way to moving all 32 bit hal ints to 64 bit? So dropping back to 32 bits temporarily? |
Contributor
Author
|
Yes, but the encoder 64bit should work if you connect to the 32bit pin, it is just the 32bit count view that is truncated, position will be correct, it's a stop gap to the getter setter discussed on #3286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC #3286 narrow option 1: fix float position wrap on high-count encoders via 64-bit internal counters, without exposing new HAL pin types. s32 count/rawcounts/rawlatch/ count-latched remain as truncated views of the internal 64-bit counters. Float position is computed from the full 64-bit value so it does not wrap.
Avoids committing four integer pin types (s32/u32/s64/u64) into 2.10 ABI before the getter/setter direction in #3286 is decided. The overflow fix from 8a3ac3f is preserved; only the pin exposure is reverted. Unused
prev_event_rawcounts_64 dropped.
BREAKING CHANGE: count_64, rawcounts_64, rawlatch_64 and count-latched_64 pins added post-2.9 are removed. HAL surface matches 2.9.
Refs #3286 #2331