Allow localization of option page's name and title#355
Open
laundy wants to merge 3 commits intoLog1x:masterfrom
Open
Allow localization of option page's name and title#355laundy wants to merge 3 commits intoLog1x:masterfrom
laundy wants to merge 3 commits intoLog1x:masterfrom
Conversation
Owner
|
Hey! Thanks for this. I'm glad you like ACF Composer. Everything looks good, but would you mind dropping the |
Author
|
Thanks for your feedback. Sure, the todo comments are removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all: Incredible work, I use the package a lot! 🤩
I've noticed that the option page is not localizable yet, so I've just added the necessary functionality. Also, I've included the
$positionin theoptions.stuband added a hint for developers to change the$position, otherwise only one (or none) will be displayed.Please also test the code and I'd be happy if the change gets merged.