-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Update todo.ejs #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update todo.ejs #276
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # node-todo-cicd | ||
|
|
||
| Run these commands: | ||
| Run these all commands: | ||
|
|
||
|
|
||
| `sudo apt install nodejs` | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -89,7 +89,7 @@ | |||||
| </head> | ||||||
|
|
||||||
| <body> | ||||||
| <h1>Hello Junoon Batch 8 (Jenkins), Write your plan on Learning Jenkins</h1> | ||||||
| <h1>Hello everyone this devopswithali (Jenkins), Write your plan on Learning Jenkins</h1> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Improve header text grammar. The current header text has grammatical issues. Consider these improvements:
- <h1>Hello everyone this devopswithali (Jenkins), Write your plan on Learning Jenkins</h1>
+ <h1>Hello everyone, this is DevOpsWithAlii (Jenkins), Write your plan on Learning Jenkins</h1>📝 Committable suggestion
Suggested change
|
||||||
| <ul> | ||||||
| <% todolist.forEach(function(todo, index) { %> | ||||||
| <li> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Revert text change for clarity.
The phrase "Run these all commands:" is grammatically incorrect and less clear than the original "Run these commands:". The word "all" is redundant since the list already implies all commands should be run.
📝 Committable suggestion