Update todo.ejs #291
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| @Library('Shared-Liabrary') _ | ||
| pipeline{ | ||
| agent { label 'Shared-Liabrary' } | ||
| stages{ | ||
| stage('clone'){ | ||
| steps{ | ||
| code_clone('https://github.com/abhishek26w/node-todo-cicd.git','master') | ||
|
|
||
| } | ||
| } | ||
|
|
||
| stage('build'){ | ||
| steps{ | ||
| docker_build('node-apk','latest') | ||
| } | ||
| } | ||
|
|
||
| stage('Test'){ | ||
| steps{ | ||
| echo "Tested Successfully" | ||
| } | ||
| } | ||
|
Comment on lines
+18
to
+22
There was a problem hiding this comment. 🛠️ Refactor suggestion Implement actual testing or document as placeholder. The test stage only echoes a success message without running any actual tests. This defeats the purpose of having a test stage in a CI/CD pipeline. Consider implementing actual tests: stage('Test'){
steps{
- echo "Tested Successfully"
+ script {
+ // Run unit tests
+ sh 'npm test'
+ // Or if using Docker for testing
+ // sh 'docker run --rm node-apk:latest npm test'
+ }
}
}Alternatively, if this is intentionally a placeholder, add a comment to clarify: stage('Test'){
steps{
+ // TODO: Implement actual tests
echo "Tested Successfully"
}
}🤖 Prompt for AI Agents |
||
|
|
||
| stage('Push to DockerHUb'){ | ||
| steps{ | ||
| docker_push('DOCKER-USER','node-apk','latest') | ||
| } | ||
| } | ||
|
|
||
| stage('Deploy'){ | ||
| steps{ | ||
| docker_compose() | ||
|
|
||
| } | ||
| } | ||
|
Comment on lines
+30
to
+35
There was a problem hiding this comment. 🧹 Nitpick (assertive) LGTM - Consider adding deployment configuration clarity. The Docker Compose deployment stage is properly structured. Consider documenting which Docker Compose file is used and the deployment target if not obvious from the shared library implementation. 🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,111 +1,125 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <title>Todo List APP - DevOps CI/CD</title> | ||
| <style> | ||
| body { | ||
| font-family: Arial, sans-serif; | ||
| background-color: #f4f4f4; | ||
| color: #333; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| .header { | ||
| background-color: #4CAF50; | ||
| color: white; | ||
| padding: 20px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .header h1 { | ||
| margin: 0; | ||
| font-size: 32px; | ||
| } | ||
|
|
||
| .header p { | ||
| margin-top: 10px; | ||
| font-size: 18px; | ||
| } | ||
|
|
||
| ul { | ||
| list-style: none; | ||
| padding: 0; | ||
| } | ||
|
|
||
| ul li { | ||
| background: #fff; | ||
| border: 1px solid #ddd; | ||
| margin-bottom: 10px; | ||
| padding: 10px; | ||
| position: relative; | ||
| } | ||
|
|
||
| ul li a { | ||
| color: #333; | ||
| text-decoration: none; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| ul li a:hover { | ||
| color: #4CAF50; | ||
| } | ||
|
|
||
| .delete-btn { | ||
| color: red; | ||
| position: absolute; | ||
| right: 10px; | ||
| top: 10px; | ||
| } | ||
|
|
||
| .edit-btn { | ||
| color: #FFC107; | ||
| position: absolute; | ||
| right: 40px; | ||
| top: 10px; | ||
| } | ||
|
|
||
| form { | ||
| background: #fff; | ||
| padding: 20px; | ||
| margin-top: 20px; | ||
| } | ||
|
|
||
| label { | ||
| display: block; | ||
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| input[type="text"] { | ||
| width: 100%; | ||
| padding: 10px; | ||
| margin-bottom: 10px; | ||
| border: 1px solid #ddd; | ||
| } | ||
|
|
||
| input[type="submit"] { | ||
| background-color: #4CAF50; | ||
| color: white; | ||
| border: none; | ||
| padding: 10px 20px; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| input[type="submit"]:hover { | ||
| background-color: #45a049; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
|
|
||
| <div class="header"> | ||
| <h1>🚀 Welcome to the DevOps CI/CD Pipeline Workshop</h1> | ||
| <p>Empowering Junoon Batch 8 to master automation using Jenkins!</p> | ||
| </div> | ||
|
|
||
| <ul> | ||
| <% todolist.forEach(function(todo, index) { %> | ||
| <li> | ||
| <a href="/todo/delete/<%= index %>" class="delete-btn">✘</a> | ||
| <a href="/todo/<%= index %>" class="edit-btn">✎</a> | ||
| <%- todo %> | ||
| </li> | ||
| <% }); %> | ||
| </ul> | ||
|
|
||
| <form action="/todo/add/" method="post"> | ||
| <p> | ||
| <label for="newtodo">What should I do?</label> | ||
| <input type="text" name="newtodo" id="newtodo" autofocus /> | ||
| <input type="submit" value="Add" /> | ||
| </p> | ||
| </form> | ||
|
|
||
| </body> | ||
| </html> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the typo in the shared library name.
The library name "Shared-Liabrary" contains a typo - it should be "Shared-Library". This typo appears in both the library import and agent label, which will cause the pipeline to fail.
Apply this diff to fix the typo:
📝 Committable suggestion
🤖 Prompt for AI Agents