feat(Modbus): add ReadHoldingRegistersAsync function#12
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements async reading functionality for Modbus holding registers and input registers, along with interface updates to support nullable return types and improved documentation.
Key changes include:
- Added
ReadHoldingRegistersAsyncandReadInputRegistersAsyncmethod implementations - Updated interface method signatures to return nullable arrays and use
ValueTaskinstead ofTask - Refactored code to use generic parsing functions for different data types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
IModbusTcpClient.cs |
Updated interface with nullable return types, consistent ValueTask usage, and improved Chinese documentation |
DefaultModbusTcpClient.cs |
Implemented async register reading methods with generic parsing approach and code refactoring |
TcpClientTest.cs |
Added comprehensive test coverage for the new async register reading methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #11
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge