feat(Modbus): add WriteCoilAsync function#16
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds asynchronous single coil write functionality to the Modbus TCP client by implementing the WriteCoilAsync method. The changes simplify the interface by removing unused synchronous methods and focus on providing a clean async-only API.
- Implements
WriteCoilAsyncmethod for writing single coil values asynchronously - Adds
BuildWriteRequestmethod to support write operations in the message builder - Removes unused synchronous methods and simplifies the interface
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/UnitTestModbus/TcpClientTest.cs | Adds unit test for the new WriteCoilAsync functionality |
| src/Longbow.Modbus/ModbusMessageBuilder.cs | Renames existing method and adds BuildWriteRequest for write operations |
| src/Longbow.Modbus/IModbusTcpClient.cs | Updates interface to include WriteCoilAsync and removes unused methods |
| src/Longbow.Modbus/DefaultModbusTcpClient.cs | Implements WriteCoilAsync and supporting write functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #15
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge