chore(TargetFramework): support NET10#34
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for .NET 10.0 by updating target frameworks and package versions across the project.
- Updated target framework to net10.0 and added it to multi-targeting configurations
- Changed NET10Version from pre-release (10.0.0-rc*) to stable (10.0.*)
- Upgraded project versions from 9.x to 10.0.0
- Converted package references to project references for internal dependencies
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Version.props | Removed VS version conditions, set default target to net10.0, updated NET10Version to stable |
| test/Directory.Build.props | Updated default target framework from net9.0 to net10.0 |
| src/Frameworks.props | Removed VS version conditions, added net10.0 to target frameworks, updated NET10Version to stable |
| src/Longbow.UdpSocket/Longbow.UdpSocket.csproj | Bumped version to 10.0.0, updated package versions, converted to project reference |
| src/Longbow.TcpSocket/Longbow.TcpSocket.csproj | Bumped version to 10.0.0, updated package versions, converted to project reference |
| src/Longbow.Sockets/Longbow.Sockets.csproj | Bumped version to 10.0.0, updated package versions for net8.0 and net9.0 conditions |
| src/Longbow.SerialPorts/Longbow.SerialPorts.csproj | Bumped version to 10.0.0, updated package versions |
| src/Longbow.Modbus/Longbow.Modbus.csproj | Bumped version to 10.0.0, converted package references to project references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net8.0', but the package version is using NET10Version (10.0.*). This should use NET8Version instead to match the appropriate package version for .NET 8.0.
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET8Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net9.0', but the package version is using NET10Version (10.0.*). This should use NET9Version instead to match the appropriate package version for .NET 9.0.
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net8.0', but the package version is using NET10Version (10.0.*). This should use NET8Version instead to match the appropriate package version for .NET 8.0.
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET8Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net9.0', but the package version is using NET10Version (10.0.*). This should use NET9Version instead to match the appropriate package version for .NET 9.0.
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net8.0', but the package version is using NET10Version (10.0.*). This should use NET8Version instead to match the appropriate package version for .NET 8.0.
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET8Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net9.0', but the package version is using NET10Version (10.0.*). This should use NET9Version instead to match the appropriate package version for .NET 9.0.
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(NET9Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net8.0', but the package version is using NET10Version (10.0.*). This should use NET8Version instead to match the appropriate package version for .NET 8.0.
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET8Version)" /> |
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> |
There was a problem hiding this comment.
The condition targets 'net9.0', but the package version is using NET10Version (10.0.*). This should use NET9Version instead to match the appropriate package version for .NET 9.0.
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET10Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(NET9Version)" /> |
Link issues
fixes #33
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge