chore(Logging): bump version 10.0.0 by ArgoZhang · Pull Request #36 · LongbowEnterprise/Longbow.Utility2026

ArgoZhang · 2025-11-15T05:25:48Z

Link issues

fixes #35

Summary By Copilot

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Copilot

Pull Request Overview

This PR introduces version 10.0.0 of the Longbow.Logging component, adding comprehensive logging functionality with support for file-based and database logging. The PR upgrades multiple Microsoft.Extensions package dependencies to version 10.* and targets .NET 10.0, which may not be stable or available yet.

Key Changes:

Added complete Longbow.Logging library with FileLogger and DBLogger implementations
Updated test project dependencies from version 9.* to 10.* for Microsoft.Extensions packages
Added comprehensive unit tests for the new logging functionality

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 27 comments.

Show a summary per file

File	Description
test/UnitTestTcpSocket/UnitTestTcpSocket.csproj	Updated Microsoft.Extensions.DependencyInjection to version 10.*
test/UnitTestSocket/UnitTestSocket.csproj	Updated Microsoft.Extensions.Options.ConfigurationExtensions to version 10.*
test/UnitTestModbus/UnitTestModbus.csproj	Updated Microsoft.Extensions.DependencyInjection to version 10.*
test/UnitTestLogging/appsettings.json	Added configuration for file logger with batch and scope settings
test/UnitTestLogging/UnitTestLogging.csproj	New test project targeting net10.0 with version 10.* dependencies
test/UnitTestLogging/TestHelper.cs	Helper class for triggering configuration file change events
test/UnitTestLogging/LoggerProviderTest.cs	Tests for LoggerProvider creation and disposal
test/UnitTestLogging/FileLoggerWriterTest.cs	Tests for file logger writer including batch processing and file rolling
test/UnitTestLogging/FileLoggerTest.cs	Tests for file logger integration with DI container (contains syntax error)
test/UnitTestLogging/DBLoggerTest.cs	Tests for database logger provider and IP address extensions
test/Directory.Build.props	Updated Microsoft.NET.Test.Sdk to version 18.*
src/Longbow.Logging/readme.zh-CN.md	Chinese documentation for the logging library
src/Longbow.Logging/readme.md	English documentation for the logging library
src/Longbow.Logging/exceptionManagement.json	Example configuration for exception logging
src/Longbow.Logging/Longbow.Logging.csproj	Project file with multi-targeting support and version 10.* package references
src/Longbow.Logging/LoggerProviderConfigureOptions.cs	Configuration helper for logger providers
src/Longbow.Logging/Logger/LoggerProvider.cs	Base logger provider implementation
src/Longbow.Logging/Logger/LoggerBase.cs	Abstract base class for logger implementations
src/Longbow.Logging/Logger/Logger.cs	Console logger implementation
src/Longbow.Logging/LogMessage.cs	Log message data structure
src/Longbow.Logging/FormatExceptionExtensions.cs	Exception formatting utilities for detailed error output
src/Longbow.Logging/FileLogger/FileLoggerWriter.cs	File writing logic with batch processing support
src/Longbow.Logging/FileLogger/FileLoggerProvider.cs	File logger provider with configuration monitoring
src/Longbow.Logging/FileLogger/FileLoggerOptions.cs	Configuration options for file logging
src/Longbow.Logging/FileLogger/FileLogger.cs	File logger implementation
src/Longbow.Logging/Extensions/FileLoggerFactoryExtensions.cs	DI registration extensions for file and database loggers
src/Longbow.Logging/DBLogger/DBLoggerProvider.cs	Database logger provider implementation
src/Longbow.Logging/DBLogger/DBLogger.cs	Database logger implementation (contains signature error)
src/Longbow.Logging/ConfigurationExtensions.cs	Configuration extensions for environment variables (contains typo)
Longbow.Utility2026.slnx	Added Longbow.Logging project to solution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-15T05:30:56Z

+/// <typeparam name="TOptions"></typeparam>
+/// <typeparam name="TProvider"></typeparam>


The empty XML comment lacks a description. Consider adding a meaningful summary that explains the purpose of the LoggerProviderConfigureOptions class.

Suggested change

/// <typeparam name="TOptions"></typeparam>

/// <typeparam name="TProvider"></typeparam>

/// <typeparam name="TOptions">The options type to be configured for the logger provider.</typeparam>

/// <typeparam name="TProvider">The logger provider type for which the options are being configured.</typeparam>

Copilot · 2025-11-15T05:30:56Z

+public abstract class LoggerBase(string name, Func<string, LogLevel, bool>? filter, IExternalScopeProvider? scopeProvider, IConfiguration? config) : ILogger
+{
+    /// <summary>
+    /// 


The empty XML comment lacks a description. Consider adding a meaningful summary that explains the purpose of the LogName property.

Suggested change

///

/// Gets the name of the logger instance.

Copilot · 2025-11-15T05:30:56Z

+    protected string LogName { get; } = name;
+
+    /// <summary>
+    /// 


The empty XML comment lacks a description. Consider adding a meaningful summary that explains the purpose of the Filter property.

Suggested change

///

/// Gets the filter function used to determine whether logging is enabled for a given category and log level.

Copilot · 2025-11-15T05:30:57Z

+public static class ConfigurationExtensions
+{
+    /// <summary>
+    /// 获得 环境变量中的 OS 属性值 近 Windows 平台有效


Typo: "近 Windows 平台有效" should be "仅 Windows 平台有效" (only valid for Windows platform).

Suggested change

/// 获得环境变量中的 OS 属性值近 Windows 平台有效

/// 获得环境变量中的 OS 属性值仅 Windows 平台有效

Copilot · 2025-11-15T05:30:57Z

+public static class TestHelper
+{
+    /// <summary>
+    /// 


The empty XML comment lacks a description. Consider adding a meaningful summary that explains the purpose of the TestHelper class.

Suggested change

///

/// Triggers a reload of the app settings file and invokes the specified callback when the configuration changes.

Copilot · 2025-11-15T05:31:01Z

+
+        // 生成过期文件
+        var file = CreateOldLogFile(fileName);
+        var folder = file.Folder;


This assignment to folder is useless, since its value is never read.

Suggested change

var folder = file.Folder;

Copilot · 2025-11-15T05:31:01Z

+
+        // 生产长度不满足内部判断条件的干扰文件
+        var fn = $"Log01.log";
+        using (var fs = File.AppendText(Path.Combine(folder, fn))) { }


This assignment to fs is useless, since its value is never read.

Suggested change

using (var fs = File.AppendText(Path.Combine(folder, fn))) { }

File.AppendText(Path.Combine(folder, fn)).Dispose();

Copilot · 2025-11-15T05:31:01Z

+
+            //
+            await Task.Delay(2000);
+            var foo = DateTime.Now;


This assignment to foo is useless, since its value is never read.

Suggested change

var foo = DateTime.Now;

Copilot · 2025-11-15T05:31:02Z

+                    if (propertyValue != null)
+                    {
+                        #region Loop through the public properties of the exception object and record their value
+                        // Loop through the public properties of the exception object and record their value.
+                        // Cast the collection into a local variable.
+                        // Check if the collection contains values.
+                        if (propertyValue is NameValueCollection currentAdditionalInfo && currentAdditionalInfo.Count > 0)
+                        {
+                            strInfo.AppendFormat("AdditionalInformation{0}", Environment.NewLine);
+                            // Loop through the collection adding the information to the string builder.
+                            foreach (string? infoKey in currentAdditionalInfo)
+                            {
+                                if (!string.IsNullOrEmpty(infoKey)) strInfo.AppendFormat("{1}: {2}{0}", Environment.NewLine, infoKey, currentAdditionalInfo[infoKey]);
+                            }


These 'if' statements can be combined.

Suggested change

if (propertyValue != null)

{

#region Loop through the public properties of the exception object and record their value

// Loop through the public properties of the exception object and record their value.

// Cast the collection into a local variable.

// Check if the collection contains values.

if (propertyValue is NameValueCollection currentAdditionalInfo && currentAdditionalInfo.Count > 0)

{

strInfo.AppendFormat("AdditionalInformation{0}", Environment.NewLine);

// Loop through the collection adding the information to the string builder.

foreach (string? infoKey in currentAdditionalInfo)

{

if (!string.IsNullOrEmpty(infoKey)) strInfo.AppendFormat("{1}: {2}{0}", Environment.NewLine, infoKey, currentAdditionalInfo[infoKey]);

}

if (propertyValue is NameValueCollection currentAdditionalInfo && currentAdditionalInfo.Count > 0)

{

#region Loop through the public properties of the exception object and record their value

// Loop through the public properties of the exception object and record their value.

// Cast the collection into a local variable.

// Check if the collection contains values.

strInfo.AppendFormat("AdditionalInformation{0}", Environment.NewLine);

// Loop through the collection adding the information to the string builder.

foreach (string? infoKey in currentAdditionalInfo)

{

if (!string.IsNullOrEmpty(infoKey)) strInfo.AppendFormat("{1}: {2}{0}", Environment.NewLine, infoKey, currentAdditionalInfo[infoKey]);

Copilot · 2025-11-15T05:31:02Z

+        if (disposing)
+        {
+            if (!disposedValue)
+            {
+                disposedValue = true;
+
+                _messageQueue.CompleteAdding();
+                _cancellationTokenSource.Cancel();
+                _logTask.Wait(Option.TaskWaitTime);
+
+                _cancellationTokenSource.Dispose();
+                _messageQueue.Dispose();
+            }


These 'if' statements can be combined.

Suggested change

if (disposing)

{

if (!disposedValue)

{

disposedValue = true;

_messageQueue.CompleteAdding();

_cancellationTokenSource.Cancel();

_logTask.Wait(Option.TaskWaitTime);

_cancellationTokenSource.Dispose();

_messageQueue.Dispose();

}

if (disposing && !disposedValue)

{

disposedValue = true;

_messageQueue.CompleteAdding();

_cancellationTokenSource.Cancel();

_logTask.Wait(Option.TaskWaitTime);

_cancellationTokenSource.Dispose();

_messageQueue.Dispose();

ArgoZhang added 8 commits November 12, 2025 13:37

feat: 增加 Longbow.Logging 工程

30a68c2

refactor: 合并注入方法

dd86c6b

chore: bump version 10.0.1

613954e

test: 更新单元测试

c6d8066

doc: 增加 readme 文档

d3e41a3

chore: 更新框架依赖到最新

d35110a

chore: bump version 10.0.0

2d94e01

chore: 更新 readme 文档

2bc9035

Copilot AI review requested due to automatic review settings November 15, 2025 05:25

ArgoZhang merged commit 28c6ade into main Nov 15, 2025
3 checks passed

ArgoZhang deleted the feat-log branch November 15, 2025 05:25

Copilot started reviewing on behalf of ArgoZhang November 15, 2025 05:26 View session

Copilot finished reviewing on behalf of ArgoZhang November 15, 2025 05:28

Copilot AI reviewed Nov 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(Logging): bump version 10.0.0#36

chore(Logging): bump version 10.0.0#36
ArgoZhang merged 8 commits into
mainfrom
feat-log

ArgoZhang commented Nov 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		/// <typeparam name="TOptions"></typeparam>
		/// <typeparam name="TProvider"></typeparam>

	///
	/// Gets the filter function used to determine whether logging is enabled for a given category and log level.

	/// 获得环境变量中的 OS 属性值近 Windows 平台有效
	/// 获得环境变量中的 OS 属性值仅 Windows 平台有效

	///
	/// Triggers a reload of the app settings file and invokes the specified callback when the configuration changes.

	using (var fs = File.AppendText(Path.Combine(folder, fn))) { }
	File.AppendText(Path.Combine(folder, fn)).Dispose();

Uh oh!

Uh oh!

Conversation

ArgoZhang commented Nov 15, 2025

Link issues

Summary By Copilot

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants