[tabs] Fix activation direction not updating on programmatic value changes#1
[tabs] Fix activation direction not updating on programmatic value changes#1
Conversation
Co-authored-by: LukasTy <4941090+LukasTy@users.noreply.github.com>
…ameter Co-authored-by: LukasTy <4941090+LukasTy@users.noreply.github.com>
|
@copilot Recreate this PR in the https://github.com/mui/base-ui repository. |
I'm unable to create PRs in other repositories. I can only work within the repository that's been cloned for me (LukasTy/base-ui). To recreate this PR in the mui/base-ui repository, you would need to:
Alternatively, you could open a new issue or PR request in the mui/base-ui repository and have me work on it directly from there. |
|
@copilot, I have updated the tests to fail in certain conditions. Update the solution so it behaves the same regardless of the tab change method. |
…ternal value changes Co-authored-by: LukasTy <4941090+LukasTy@users.noreply.github.com>
... Fixed in ddb7c51. The issue was that external value changes computed the direction in a layout effect after the render, so the panels received the old direction. The solution moves direction computation to Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
tabActivationDirectionstate was not available in the same render cycle for programmatic value changestabsListElementstate toTabsRootand expose it via contextTabsListdirection calculation for internal clicksOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.