Open
Conversation
| private: | ||
| uint32_t warm_up_load_{ 0 }; | ||
|
|
||
| VkCommandPool command_pool_{ VK_NULL_HANDLE }; |
Contributor
There was a problem hiding this comment.
I think other places are creating very similar temporary Vulkan objects in order to submit command buffers for execution via a QueueSubmit. Resource initializer, virtual swapchain, screenshot handler, dump resources and address replacer comes to mind without checking. I wonder if it would be a good idea to create a utility class that handles creation and destruction of such objects (of course as a separate PR and not as part of this)
antonio-lunarg
force-pushed
the
antonio-warm-up
branch
7 times, most recently
from
6f73faa to
f1e9214
Compare
antonio-lunarg
added
the
approved-to-run-ci
antonio-lunarg
force-pushed
the
antonio-warm-up
branch
8 times, most recently
from
351d25d to
7c00647
Compare
nickdriscoll-lunarg
approved these changes
Mar 12, 2026
antonio-lunarg
force-pushed
the
antonio-warm-up
branch
from
7c00647 to
72450e9
Compare
The `--frame-warm-up-spirv` option can be used to provide a SPIR-V compute shader for the compute warm-up pass before replay frame work. The `--frame-warm-up-load` option is a workload scale factor: higher values increase warm-up work by scaling compute dispatch workgroups, while `0` keeps warm-up disabled. This helps ramp/stabilize GPU frequency before each frame so performance measurements are less sensitive to clock ramp-up latency. Co-authored-by: Oleh Kuznetsov <okuznetsov@google.com>
antonio-lunarg
force-pushed
the
antonio-warm-up
branch
from
72450e9 to
27bb5a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--frame-warm-up-loadoption controls a synthetic compute warm-up pass submitted before replay frame work. This helps ramp/stabilize GPU frequency before each frame so performance measurements are less sensitive to clock ramp-up latency.frame_warm_up_loadis a workload scale factor: higher values increase warm-up work by scaling compute dispatch workgroups, while0keeps warm-up disabled.