Skip to content

allow --log-level option in info#2714

Merged
bradgrantham-lunarg merged 1 commit intoLunarG:devfrom
bradgrantham-lunarg:brad-info-integrate-tool-settings
Mar 5, 2026
Merged

allow --log-level option in info#2714
bradgrantham-lunarg merged 1 commit intoLunarG:devfrom
bradgrantham-lunarg:brad-info-integrate-tool-settings

Conversation

@bradgrantham-lunarg
Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg commented Feb 20, 2026

  • Include tool_settings.h and take advantage of that
  • Add log-level as an option
    • This allows output to stdout but blocking warning output from consumers like state setup or the frame marker warning, using e.g. "gfxrecon-info --log-level error"

Before this change, the output of "gfxrecon-info --verbose" could not be reliably parsed as JSON because the output may have had logging warning or info messages interspersed in it. This is a change in line with #1917

@bradgrantham-lunarg bradgrantham-lunarg requested a review from a team as a code owner February 20, 2026 20:38
@bradgrantham-lunarg bradgrantham-lunarg added the approved-to-run-ci Can run CI check on internal LunarG machines label Feb 20, 2026
@bradgrantham-lunarg bradgrantham-lunarg changed the title allow the log-level option allow the log-level option in info Feb 20, 2026
@bradgrantham-lunarg bradgrantham-lunarg changed the title allow the log-level option in info allow --log-level option in info Feb 20, 2026
@bradgrantham-lunarg bradgrantham-lunarg force-pushed the brad-info-integrate-tool-settings branch from 948fb9f to 3443e1b Compare March 4, 2026 17:36
* Include tool_settings.h and take advantage of that
* Add log-level as an option
  * This allows output to stdout but blocking warning output from
    consumers like state setup or the frame marker warning
@bradgrantham-lunarg bradgrantham-lunarg force-pushed the brad-info-integrate-tool-settings branch from 3443e1b to 76f90bf Compare March 5, 2026 15:04
@bradgrantham-lunarg bradgrantham-lunarg merged commit 9eaa6c1 into LunarG:dev Mar 5, 2026
8 checks passed
zongdu-arm pushed a commit to zongdu-arm/gfxreconstruct that referenced this pull request Mar 6, 2026
* Include tool_settings.h and take advantage of that
* Add log-level as an option
  * This allows output to stdout but blocking warning output from
    consumers like state setup or the frame marker warning

Bypass rules because info/ hasn't changed since last successful test run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-to-run-ci Can run CI check on internal LunarG machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants