VDR: Fix use after free crash#2733
Merged
panos-lunarg merged 4 commits intoLunarG:devfrom Mar 14, 2026
Merged
Conversation
panos-lunarg
force-pushed
the
VDR_fix_use_after_free_crash
branch
from
a58e9a0 to
8b53115
Compare
panos-lunarg
added
approved-to-run-ci
panos-lunarg
force-pushed
the
VDR_fix_use_after_free_crash
branch
5 times, most recently
from
4f14e40 to
c6d8064
Compare
Contributor
|
Does this argue that |
panos-lunarg
force-pushed
the
VDR_fix_use_after_free_crash
branch
3 times, most recently
from
90aaf35 to
3f12bdb
Compare
Contributor
Author
|
panos-lunarg
force-pushed
the
VDR_fix_use_after_free_crash
branch
3 times, most recently
from
9aae0d8 to
326026c
Compare
bradgrantham-lunarg
approved these changes
Mar 13, 2026
Contributor
bradgrantham-lunarg
left a comment
bradgrantham-lunarg
left a comment
There was a problem hiding this comment.
We discussed having a follow-on to this PR making some changes to bare pointers in these structures, but this PR 2733 has been in testing for some time so should get merged with the follow-on shortly after. Thank you!
Reserving space in the build_infos vector should fix a crash of referencing a dangling pointer when the infoCount was larger than 1.
Remove return causing interruption of loop
panos-lunarg
force-pushed
the
VDR_fix_use_after_free_crash
branch
from
326026c to
d4e190f
Compare
bradgrantham-lunarg
pushed a commit
to bradgrantham-lunarg/gfxreconstruct
that referenced
this pull request
Mar 16, 2026
* VDR: Fix use after free crash Reserving space in the build_infos vector should fix a crash of referencing a dangling pointer when the infoCount was larger than 1. * VDR: Remove return Remove return causing interruption of loop * VDR: Fix null entry in json output * VDR: Add new test for VDR_2733
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
* Fix issues for d3d12 (#2633) 1.Add RASTERIZER1 and RASTERIZER2 support in CreatePipelineState 2.Add no array struct pointer handling 3.Add DEPTH_STENCIL2 and SERIALIZED_ROOT_SIGNATURE support in CreatePipelineState 4.Fix incorrect code * Remove busy-wait loops for vkGetEventStatus and vkGetQueryPoolResult (#2723) - no more looping, no blocking-wait, just invoke func once, be happy with whatever it returns - allow-list both functions, other return-types are expected and should be benign - instead log debug-messages - behavior is more predictable and better matches GFXR guidelines - log-spam is reduced significantly for replay of proton/DXVK * Revert "Fix memory leak during D3D12 capture (#2740)" (#2771) This reverts commit 865a785. * fix NVIDIA label (#2772) * Remove concurrency line from extended manual jenkinsfile * Change block allocation to HLA in BlockBatch Implement block batch targeted hybrid linear allocator * Remove DispatchStore in favor of all HLA model Also Cleanups for HLA Streamlined allocator reset and block buffer Fix replay time decompression glass jaw error. Change to decompression policy kAlways to optimize replay performance. Cleanup BlockBuffer Cleanup iterator safety Review/CI based fixes Iterator performance tuning Remove unused HeapBufferPool * Fix memory leak during D3D12 capture (#2775) * Fix memory leak during D3D12 capture * Update test_suite.ref * replay: Add --idle-before-submit option Add a replay option to wait for the GPU to become idle before submitting each command buffer to a queue. * Update headers to 1.4.345 (#2780) * Update headers to 1.4.345 * Add python pyparsing module dependency to github actions * VDR: Fix use after free crash (#2733) * VDR: Fix use after free crash Reserving space in the build_infos vector should fix a crash of referencing a dangling pointer when the infoCount was larger than 1. * VDR: Remove return Remove return causing interruption of loop * VDR: Fix null entry in json output * VDR: Add new test for VDR_2733 * Fix test_suite.ref (#2784) * VDR: Some changes in generated filenames (#2726) - The capture filename prefix is removed from the dumped files. This should help shorten the generated names. - Add the command index that was missing from some filenames. This should help reduce naming collisions * Foo --------- Co-authored-by: zongdu-arm <zongshou.du@arm.com> Co-authored-by: Fabian Schmidt <165773884+fabian-lunarg@users.noreply.github.com> Co-authored-by: Beau Bennett <beau@lunarg.com> Co-authored-by: John Zulauf <jzulauf@lunarg.com> Co-authored-by: Locke Lin <47329816+locke-lunarg@users.noreply.github.com> Co-authored-by: Antonio Caggiano <antonio@lunarg.com> Co-authored-by: David Pinedo <david@lunarg.com> Co-authored-by: Panagiotis Apostolou <104391532+panos-lunarg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserving space in the build_infos vector should fix a crash of referencing a dangling pointer when the infoCount was larger than 1.