Open
Conversation
|
|
Before when replaying captures from a different device --wsi <WSI> had to be specified explicitly and the --wsi auto options was ignored. Even when captures recorded on the same device were replayed the --wsi auto option was ignored and the surface from the capture device was chosen. Now the --wsi auto option (already default behaviour) picks the surface extension from the capture device if it is available. Otherwise the first available surface extension of the replay device is used. If there was not surface extensions available on the capture device, all --wsi options are ignored and a warning is emitted. Furthermore, a check if a compositor is available is made after initializing the WSIContext. Documentation and cli --help commands were updated to reflect these changes. Change-Id: I578ee1f50a797ec81a9b48ab3ee4b4a9817a91bf
fabian-lunarg
added
the
approved-to-run-ci
…ing different WSI
Contributor
|
investigating an issue our internal CI had with a replay of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before when replaying captures from a different device --wsi had to be specified explicitly and the --wsi auto options was ignored. Even when captures recorded on the same device were replayed the --wsi auto option was ignored and the surface from the capture device was chosen.
Now the --wsi auto option (already default behaviour) picks the surface extension from the capture device if it is available. Otherwise the first available surface extension of the replay device is used. If there was not surface extensions available on the capture device, all --wsi options are ignored and a warning is emitted. Furthermore, a check if a compositor is available is made after initializing the WSIContext.
Documentation and cli --help commands were updated to reflect these changes.