Merged
Conversation
fabian-lunarg
approved these changes
Mar 2, 2026
MarkY-LunarG
approved these changes
Mar 2, 2026
Spec mandates that pData in vkGetRayTracingShaderGroupHandlesKHR should be not be null. However applications can incorrectly pass a null pointer which, for debug builds, leads to an assertion failure, but for release builds it causes us to crash. This should make OverrideGetRayTracingShaderGroupHandlesKHR to handle this case without crashing.
If creation of pipeline fails, forwarind a VK_NULL_HANDLE as an object down vkSetDebugUtilsObjectNameEXT can cause a seg fault.
panos-lunarg
force-pushed
the
fix_for_two_crashes
branch
from
0fc9b90 to
5a72bcc
Compare
zongdu-arm
pushed a commit
to zongdu-arm/gfxreconstruct
that referenced
this pull request
Mar 6, 2026
* Handle null pData in GetRayTracingShaderGroupHandles Spec mandates that pData in vkGetRayTracingShaderGroupHandlesKHR should be not be null. However applications can incorrectly pass a null pointer which, for debug builds, leads to an assertion failure, but for release builds it causes us to crash. This should make OverrideGetRayTracingShaderGroupHandlesKHR to handle this case without crashing. * Fix crash in address replacer If creation of pipeline fails, forwarind a VK_NULL_HANDLE as an object down vkSetDebugUtilsObjectNameEXT can cause a seg fault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.