Package / Actions Cleanup - Continuation of #435#436
Merged
simmsa merged 78 commits intoMHKiT-Software:developfrom Apr 13, 2026
Merged
Package / Actions Cleanup - Continuation of #435#436simmsa merged 78 commits intoMHKiT-Software:developfrom
simmsa merged 78 commits intoMHKiT-Software:developfrom
Conversation
There is a bug where something in requiring pyarrow that is likely related to pandas 3.0. Adding pyarrow as a dependency is a reasonable fix, but managing the pyarrow version should be handled by pandas and not mhkit. This pins pandas below 3.0 to see if pyarrow dependencies are caused by including >= 3.0 somewhere.
``` prepare-nonhindcast-cache The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'. ```
Previously we had `python>=3.10,<3.13` but this was likely legacy from the conda-forge version of the conda config. This removes the ambiguous python version, which relied on the solver, to a deterministic version with the intent of providing reproducible builds for conda users.
jmcvey3
reviewed
Mar 17, 2026
| **Pip development** (no conda): | ||
|
|
||
| ```bash | ||
| pip install -e ".[all,dev]" |
Contributor
There was a problem hiding this comment.
Just adding a note to create and activate a venv environment here
Contributor
Author
There was a problem hiding this comment.
Good call, will update accordingly. LMK if other areas don't make sense here either, or could be clarified.
These changes were a reaction to failing tests, but it is likely that the failing tests were not caused by this code specifically, but pandas 3.0 updates. This reverts these changes back to the develop branch as they are likely unnecessary for the tests to pass when pandas is pinned below 3.0
``` FAILED .github/workflows/test_read_adp.py::io_adp_testcase::test_io_nortek - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/MHKiT-Python/MHKiT-Python/examples/data/dolfyn/AQD_HR.prf' ```
Contributor
Author
|
@jmcvey3, I removed the CDIP changes in this PR, and the tests now pass. This suggests the test failures you saw were related to the pandas 3.0 update. I plan to use your changes in the upcoming PR for pandas 3.0, but just wanted to give you a heads up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation and refinement of #435
Highlights:
From #435
Dependencies
Module Dependencies
allConda and Conda-Forge Dependency Definitions
Actions
Linting
blackon files that have changedCoveralls
Error: Bad response: 530 error code: 1016per: https://status.coveralls.io/ and this implements the recommendedfail-on-error: falsefixWe can incorporate this into #435 if that makes sense. My main goal here is to understand what changes are necessary in #435