Make normalization stable when target_dtype is float16#2941
Merged
FabianIsensee merged 1 commit intoMIC-DKFZ:masterfrom Mar 13, 2026
Merged
Make normalization stable when target_dtype is float16#2941FabianIsensee merged 1 commit intoMIC-DKFZ:masterfrom
FabianIsensee merged 1 commit intoMIC-DKFZ:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1e-8may be unstable when working float16.From the code it seems like the target_dtype will always be fp32 (
target_dtypeis never explicitly passed so always is the default), but this proposed change makes things robust for future changes or if users end up using a normalization scheme withtarget_dtypefloat16.