Improve thread safety of value and readeval #4086
Draft
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes several variables thread local so that value and readeval in interp.dd is more thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes several variables thread local so that value and readeval in interp.dd is more thread safe. This seems to fix #3927.
There are a couple more variables that are worth investigating:
previousLineNumberin interp.dd I think this is only used by the interactive prompt, and so it is probably fine either as thread local or globalintepreterDepth,errorDepth, andloadDepth. These are somewhat related, but currently onlyloadDepthis thread localcurrent, this seems to be only used by the debugger. Similarly topreviousLineNumberit's probably fine for it to be either thread local or global, but we should think about it.