-
Notifications
You must be signed in to change notification settings - Fork 269
Update setupEmacs() so that it builds a package #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
What's the advantage here, and are the tests testing anything? A big disadvantage seems to be that it doesn't work if the user has a variant of emacs installed or if the path to emacs is not known by M2. |
|
Several advantages:
Good point regarding M2 not knowing how to find emacs. Perhaps we could add It would definitely be good to test this with several Emacs variants. |
|
I don't know what's the idea with the last few commits but I'm highly opposed. M2 documentation doesn't need lisp syntax highlighting ... you can put extra stuff on the wiki if absolutely necessary, but even then I think it's unnecessary. |
|
Fair enough -- I guess I did go a bit overboard! I'll remove them. |
We now build a tarball and install it using package-install-file. This way, the package files will be byte-compiled and it will appear with the list of other packages that users install from melpa, etc.
307613d to
09e42ed
Compare
|
I think this is ready now. Now, the code in |
We now build a tarball and install it using
package-install-file. This way, the package files will be byte-compiled and it will appear with the list of other packages that users install from melpa, etc.