Conversation
This reverts commit 66285d7.
|
✔️ Deploy Preview for nano-notes ready! 🔨 Explore the source changes: c4164e2 🔍 Inspect the deploy log: https://app.netlify.com/sites/nano-notes/deploys/60ff869dedc9fd0008c30039 😎 Browse the preview: https://deploy-preview-1--nano-notes.netlify.app |
kushanksriraj
left a comment
kushanksriraj
left a comment
There was a problem hiding this comment.
Clean code and good files structure.
| const { notesState, notesDispatch } = useNotes(); | ||
| const {baseURL} = useBaseURL() | ||
|
|
||
| const search = async (search_string) => { |
There was a problem hiding this comment.
Keep your variable names in camelCase: searchString
| @@ -0,0 +1,26 @@ | |||
| export const validate = (values) => { | |||
| let errors = { name: "", email: "", password: "", cpassword: "" }; | |||
There was a problem hiding this comment.
cpassword is too cryptic, have more descriptive var name like confirmPassword
| @@ -0,0 +1,71 @@ | |||
| /*Code Copied From https://codepen.io/tobiasahlin/pen/JVmLRa */ | |||
There was a problem hiding this comment.
Better to keep CSS file names without underscore, hyphen would be a better choice here.
| @@ -0,0 +1,11 @@ | |||
| export const useBaseURL = () => { | |||
There was a problem hiding this comment.
This custom hook doesn't have a state or calls any other hook, so you can have this as a normal JS function.
2 participants
Live link: https://nano-notes.netlify.app/
Express Server- https://nano-notes-backend.maddydev.repl.co