FTM: use last_direction_bits and axis did_move for direction and motion#28331
Open
narno2202 wants to merge 8 commits intoMarlinFirmware:bugfix-2.1.xfrom
Open
FTM: use last_direction_bits and axis did_move for direction and motion#28331narno2202 wants to merge 8 commits intoMarlinFirmware:bugfix-2.1.xfrom
narno2202 wants to merge 8 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
Contributor
Author
|
CI fails for Rambo with "The data size (8847 bytes) is greater than maximum allowed (8192 bytes)". should be adapted in the test build for this motherboard. |
Contributor
|
Setting FTM_BUFFER_SIZE to 64 and FTM_MIN_SHAPE_FREQ TO 35 should clear enough RAM for ATMEGA2560 |
1bc0732 to
72c7874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal is to use the already defined variables
axis_did_moveandlast_direction_bitswithFT_MOTION.axis_did_movereplaceaxis_moving_flagsas is.last_directions_bitsreplaceaxis_move_diras is but it's updated if necessary on every call toftMotion.stepper().discard_current_block()instepper.h, as it's utilized only with standard motion.Changes are independent of the printer type and now common to the 2 motion systems.
This change allows universal
axis_is_moving(const AxisEnum real)andaxis_direction(const AxisEnum real)functions.It's totally transparent for people having only
FT_MOTIONas a motion system; it diminishes flash size if you have both motion systems.Requirements
Benefits
Configurations
Related Issues
None