Skip to content

OSX Makefile changes - #218

Open
Digicrat wants to merge 2 commits into
MatMoul:masterfrom
Digicrat:master
Open

OSX Makefile changes#218
Digicrat wants to merge 2 commits into
MatMoul:masterfrom
Digicrat:master

Conversation

@Digicrat

@Digicrat Digicrat commented Mar 16, 2020

Copy link
Copy Markdown

See #174

@Digicrat Digicrat mentioned this pull request Mar 16, 2020
Open
@MatMoul

MatMoul commented Apr 28, 2020

Copy link
Copy Markdown
Owner

Duplicate with #193
Some diff but is g810-led working for OSX?

@aprovera

aprovera commented May 6, 2020 •
edited
Loading

Copy link
Copy Markdown

With the prerequisite dependency (brew install hidapi) installed, and after applying the makefile changes made by @Digicrat I can successfully compile it on OS X (v10.13).

sudo make install however does not work correctly because OS X doesn't allow users to mess with /usr/bin. /usr/local/bin would be the right install path in this case.

The software itself only appears to work correctly when run with sudo, however. When run without root privileges it returns a Matching or compatible device not found ! error.

Also worthy of note, OS X uses launchd instead of systemd. The way of having the utility start automatically on boot on OS X is making a Launch Daemon.

aprovera
aprovera reviewed May 6, 2020
View reviewed changes
Comment thread makefile
lib/lib$(PROGN).so: $(LIBSRCS)
@mkdir -p lib
$(CXX) $(CPPFLAGS) $(CXXFLAGS) $(LDFLAGS) -fPIC -shared -Wl,-soname,lib$(PROGN).so -o lib/lib$(PROGN).so.$(MAJOR).$(MINOR).$(MICRO) $^ $(LIBS)
$(CXX) $(CPPFLAGS) $(CXXFLAGS) $(LDFLAGS) -fPIC -shared $(LINKFLAGS) -o lib/lib$(PROGN).so.$(MAJOR).$(MINOR).$(MICRO) $^ $(LIBS)

@aprovera aprovera May 6, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be $(LINK_FLAGS) instead of $(LINKFLAGS)?

@FelikZ

FelikZ commented Oct 29, 2024 •
edited
Loading

Copy link
Copy Markdown

brew install hidapi

this^ and the following:

-LINKFLAGS
+LINK_FLAGS

and

LDFLAGS="-L/opt/homebrew/Cellar/hidapi/0.14.0/lib" CXXFLAGS="-I/opt/homebrew/Cellar/hidapi/0.14.0/include" make all

Compiles on Sonoma 14.7 with a latest version of g810-led (0.4.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aprovera aprovera aprovera left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

duplicate help wanted need investigation partially accepted review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Digicrat @MatMoul @aprovera @FelikZ