-
Notifications
You must be signed in to change notification settings - Fork 38
Fixes to property definitions #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to property definitions #579
Conversation
Add examples for site_coordinate_span in YAML schema
Fair point. We cannot just give OPTIMADE unit pointers, as OPTIMADE units would not cover compound units (
Diff does not show this - maybe you had in mind the size constraint? |
|
Maybe not, these were all valid schema constructs, just wrong values |
Sorry, it was a typo, I meant the symmetry operations list ( |
schemas/src/defs/v1.2/properties/optimade/structures/space_group_symmetry_operations_xyz.yaml
Show resolved
Hide resolved
…symmetry_operations_xyz
|
Sorry for updating a few more issues after your first reviews; but this should be it for this PR. |
While completing the changes for the trajectory property definitions a number of smaller issues with the property definitions already in the repository has come up. This PR separates those changes out, to avoid merging the discussion about these adjustments and the trajectory-related ones.
One interesting note is that our schemas are unable to validate the special values of
x-optimade-unitsince the unit specification can itself be any string. So it is easy for incorrectly written versions of the standard values to slip trough. I'm not sure what to do about that.Also, I'm adding a dimension name to the
Wyckofflist of symmetry operations (space_group_symmetry_operations_xyz.yaml). I'm not 100% it absolutely is required by the specification, but it also seems reasonable given that, as far as I know, we name all our other dimensions. (This enters when I have to create a list of theWyckoffsymops lists for the trajectories endpoint...)Edit: I also see that the
compactabledefinition of the meta-schema made it in here. I guess it is correct that this is a fix since the description ofcompactableis already in the specification.