Skip to content

Added loading screen and transition to move between screens and new scoreboard and new button style#46

Open
JR-EMAD wants to merge 8 commits intoMatinAfzal:developfrom
JR-EMAD:main
Open

Added loading screen and transition to move between screens and new scoreboard and new button style#46
JR-EMAD wants to merge 8 commits intoMatinAfzal:developfrom
JR-EMAD:main

Conversation

@JR-EMAD
Copy link
Copy Markdown

@JR-EMAD JR-EMAD commented Feb 8, 2025

A loading screen that is shown to the user when opening the game, with the game logo in the middle.
you can turn it off/on in settings.py
Untitled design
this gif is recorded before programing new scoreboard

Adding transitions means that when buttons such as Play Credits and Back are clicked, the page does not change suddenly, and a transition is played to change the page.

new scoreboard with animation and more things

new button style

@JR-EMAD JR-EMAD marked this pull request as draft February 8, 2025 14:05
@JR-EMAD JR-EMAD changed the title Added loading screen and transition to move between screens Added loading screen and transition to move between screens and new scoreboard Feb 8, 2025
@JR-EMAD JR-EMAD marked this pull request as ready for review February 8, 2025 14:10
@MatinAfzal
Copy link
Copy Markdown
Owner

A loading screen that is shown to the user when opening the game, with the game logo in the middle. Untitled design Untitled design this gif is recorded before programing new scoreboard

Adding transitions means that when buttons such as Play Credits and Back are clicked, the page does not change suddenly, and a transition is played to change the page.

new scoreboard with animation and more things

Thanks so much for your changes. I can definitely see the potential of the loading feature you're working on—it could be really great! However, I’d like to suggest adding one important feature.

When developing a game, sometimes we want to test things quickly to check if they work as expected. Having the loading fade in every time can be a bit time-consuming during that process. Would it be possible to add a variable in the settings called debug_mode = False? This way, when we’re working on the game, we can simply set the flag to True and skip the fade animation for developers, allowing for faster iteration.

Thanks again for your work! I’ll review your PR once this feature is added and look forward to merging it. ❤️🪴

@MatinAfzal MatinAfzal added the enhancement New feature or request label Feb 8, 2025
@JR-EMAD JR-EMAD marked this pull request as draft February 8, 2025 16:27
@JR-EMAD JR-EMAD marked this pull request as ready for review February 8, 2025 16:33
@JR-EMAD
Copy link
Copy Markdown
Author

JR-EMAD commented Feb 8, 2025

debug_mode = False
now you can turn off/on loading screen

@JR-EMAD JR-EMAD changed the title Added loading screen and transition to move between screens and new scoreboard Added loading screen and transition to move between screens and new scoreboard and new button style Feb 8, 2025
@JR-EMAD
Copy link
Copy Markdown
Author

JR-EMAD commented Feb 8, 2025

just for fun i added new style for buttons

Copy link
Copy Markdown
Owner

@MatinAfzal MatinAfzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing star_icon.png file reference.

The star_icon.png file is not included in the current project, leading to an error in the following code:

File "***\Alien-invasion\src\scoreboard.py", line 22, in __init__ 
    self.icon = pygame.image.load("data/assets/images/star_icon.png")  # Replace with your icon path
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@MatinAfzal MatinAfzal added the bug Something isn't working label Feb 9, 2025
@JR-EMAD
Copy link
Copy Markdown
Author

JR-EMAD commented Feb 15, 2025

sorry i forget to add star image

@MatinAfzal MatinAfzal added help wanted Extra attention is needed and removed bug Something isn't working labels Feb 18, 2025
@MatinAfzal
Copy link
Copy Markdown
Owner

sorry i forget to add star image

Sorry for the delayed response, I was working on another project.

Your PR had been reviewed previously, and there was an issue that you addressed by adding a star logo to the PR. However, due to the delay in adding it, two other PRs (#55 and #56) were merged, which significantly changed the project structure. As a result, there are now some conflicts between your PR and the current develop branch.

Unfortunately, I currently don’t have the time to resolve these conflicts, so I’ve marked the label as "Help Wanted" in case anyone (or you) can address them. Once the conflicts are resolved, I'll be happy to merge it.

Thank you for your contribution! ❤️🪴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants